Hey there, let's break down why your currentvalue isn't updating and fix this step by step!

First, Diagnose the Root Cause #

Your code runs without errors but doesn't update the value—here are the most likely culprits:

1. Incorrect Fragment Instance or Manager Usage #

• In Fragment 2, using fragmentManager is deprecated; you should use parentFragmentManager instead to access the parent's fragment manager.
• The R.id.mainFragment might not match the actual ID of your MainFragment in the layout (double-check your XML where MainFragment is added, whether via <fragment> tag or dynamic transaction).
• The fragment instance might be null (even with !! and as?, if the fragment isn't attached or found, the code silently skips the assignment).

2. Variable Visibility (Less Likely but Worth Checking) #

If your currentvalue in MainFragment is marked private, Fragment 2 can't access it. Kotlin defaults to public visibility, but confirm it's defined at the class level, not inside a function or inner scope:

// Correct (class-level, public by default)
class MainFragment : Fragment() {
    var currentvalue = 0
    // ... rest of code
}

Solution 1: Fix Direct Instance Access (Quick Fix) #

If you want to stick with direct instance access, adjust your code to verify the fragment exists and use the correct manager:

button.setOnClickListener { 
    val mainFragment = parentFragmentManager.findFragmentById(R.id.mainFragment) as? MainFragment
    if (mainFragment != null) {
        mainFragment.currentvalue = 10
        // Add a log to confirm the update
        Log.d("Fragment2", "Updated value to ${mainFragment.currentvalue}")
    } else {
        Log.e("Fragment2", "MainFragment not found! Check layout ID or fragment attachment.")
    }
}

This will help you debug if the fragment instance is missing.

Solution 2: Use Shared ViewModel (Recommended Best Practice) #

Directly modifying another fragment's variables isn't ideal—it creates tight coupling and breaks when fragments are recreated (e.g., screen rotation). Google recommends using a Shared ViewModel to share data between fragments safely:

Step 1: Create a Shared ViewModel #

import androidx.lifecycle.ViewModel

class SharedValueViewModel : ViewModel() {
    // Use MutableLiveData if you need to observe changes in MainFragment
    var currentvalue = 0
    // Or for reactive updates:
    // val currentvalue = MutableLiveData<Int>().apply { value = 0 }
}

Step 2: Access ViewModel in MainFragment #

import androidx.fragment.app.viewModels

class MainFragment : Fragment() {
    // Use activityViewModels() to share the same instance across fragments in the same activity
    private val sharedViewModel: SharedValueViewModel by activityViewModels()

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)
        // Initialize or use the shared value
        // If using LiveData, observe changes:
        // sharedViewModel.currentvalue.observe(viewLifecycleOwner) { newValue ->
        //     // Update UI or local state here
        // }
    }
}

Step 3: Update Value in Fragment 2 #

import androidx.fragment.app.viewModels

class Fragment2 : Fragment() {
    private val sharedViewModel: SharedValueViewModel by activityViewModels()

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)
        button.setOnClickListener {
            sharedViewModel.currentvalue = 10
            // If using LiveData:
            // sharedViewModel.currentvalue.value = 10
        }
    }
}

This approach keeps your fragments decoupled, preserves data through configuration changes, and follows Android architecture guidelines.

Solution 3: Interface Callback (Alternative for Simple Cases) #

If you prefer not to use ViewModel, use an interface to communicate between fragments:

Step 1: Define a Callback Interface #

interface ValueUpdateCallback {
    fun onValueUpdated(newValue: Int)
}

Step 2: Implement Interface in MainFragment #

class MainFragment : Fragment(), ValueUpdateCallback {
    var currentvalue = 0

    override fun onValueUpdated(newValue: Int) {
        currentvalue = newValue
        // Update UI or perform other actions here
    }
}

Step 3: Trigger Callback from Fragment 2 #

class Fragment2 : Fragment() {
    private var callback: ValueUpdateCallback? = null

    override fun onAttach(context: Context) {
        super.onAttach(context)
        // Get the callback instance from MainFragment
        callback = parentFragmentManager.findFragmentById(R.id.mainFragment) as? ValueUpdateCallback
    }

    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
        super.onViewCreated(view, savedInstanceState)
        button.setOnClickListener {
            callback?.onValueUpdated(10)
        }
    }

    override fun onDetach() {
        super.onDetach()
        callback = null // Avoid memory leaks
    }
}

内容的提问来源于stack exchange，提问作者FreeDevGer