First, let's tackle the error you're seeing: std::vector<Musician> aMuscian expression must have class type on the line if (aMuscian[i].code.find(s.at(0)) != std::string::npos).

Root Cause of the Error #

Look at your Musician struct definition:

struct Musician { char code; int impact; };

The code member is a char, not a std::string. The find() method is only available for std::string objects—char doesn't have this member function. The compiler is complaining because it expected a class/object type (like string) that has a find() method, but you gave it a primitive char instead.

Quick Fix for the Error #

Replace that problematic if condition with a direct char comparison, since you're checking if the single character code matches s.at(0):

if (aMuscian[i].code == s.at(0))

Other Critical Issues to Fix #

While we're at it, let's address other bugs and improvements in your code:

1. Vector Insertion Mistake
   std::vector doesn't have a push() method—use push_back() to add elements to the vector:

   aMuscian.push_back( /* your Musician object constructed from file data */ );
   

2. Typos in Variable Names
   You have a typo in readmuscianFile: return aMuscican; should be return aMuscian; (missing an 'i').

3. Hardcoded Loop Bound
   The loop for (int i = 0; 10 > i; i++) assumes there are exactly 10 musicians, which is fragile. Instead, loop over the actual size of the vector to avoid out-of-bounds access or missing elements:

   for (int i = 0; i < aMuscian.size(); i++)
   

4. Inefficient String-to-Int Conversion
   Converting a single character to a string just to use stoi() is unnecessary. You can get the integer value directly using ASCII arithmetic:

   int num1 = s.at(1) - '0';
   

   This works because ASCII values for digits are sequential—subtracting the ASCII value of '0' gives the numeric equivalent of the character.

5. Undefined Split Function
   Make sure your Split function is properly defined and returns a std::vector<std::string> where each element is a 2-character string (since you're splitting by 2).

6. Avoid Global Variables
   Using a global aMuscian vector is bad practice—it makes your code harder to test and debug. Instead, pass the vector returned by readmuscianFile as a parameter to overallbandPotential:

   double overallbandPotential(std::string bandMembers, const std::vector<Musician>& musicians) {
       // use the musicians parameter instead of the global aMuscian
   }
   

Corrected Code Example #

Here's how your code might look with all these fixes applied:

#include <vector>
#include <string>
// Assume Split is defined as: std::vector<std::string> Split(const std::string& s, int chunkSize);

struct Musician { 
    char code; 
    int impact; 
};

std::vector<Musician> readMusicianFile(std::string fileName) {
    std::vector<Musician> musicians;
    // Replace with actual file reading logic to populate musicians
    // Example: musicians.push_back({'A', 5});
    return musicians;
}

double overallbandPotential(std::string bandMembers, const std::vector<Musician>& musicians) {
    int totalPotential = 30;
    for (const std::string& s : Split(bandMembers, 2)) {
        // Guard against invalid chunk size
        if (s.size() < 2) continue;
        
        char memberCode = s.at(0);
        int multiplier = s.at(1) - '0';
        // Validate the multiplier is a valid digit
        if (multiplier < 0 || multiplier > 9) continue;
        
        for (const Musician& m : musicians) {
            if (m.code == memberCode) {
                totalPotential += multiplier * m.impact;
                break; // Exit loop early once we find a matching musician
            }
        }
    }
    return static_cast<double>(totalPotential);
}

内容的提问来源于stack exchange，提问作者DickChang