Let's break down the issues in your code and fix them step by step:

1. Critical Typo in Function Argument #

First off, you've got a typo: collpase should be collapse in your paste call. This small mistake is preventing R from properly merging the reversed characters into a single string—instead, it's treating the misspelled argument as extra text to paste, which messes up your reversed sequence right from the start.

2. Handling Unrecognized Bases (Like N) #

Your output includes N values, which tells me your input sequence has unknown bases marked as N. Your current map doesn't include a mapping for N, so when you try to look up N in the map, it returns NA. When you paste those NAs, they'd normally turn into "NA", but since you want to keep N as-is, you need to add N = "N" to your complement mapping.

3. Simplifying Redundant Code #

Your nested sapply(lapply(...)) is overcomplicating things. Since strsplit returns a list with just one element (for a single input sequence), you can directly access that element with [[1]] to streamline the process.

Corrected Working Code #

Here's a cleaned-up, reliable version of your function:

reverse_complement <- function(y) {
  # Define complement mapping, including N for unknown bases
  map <- c("A" = "T", "T" = "A", "G" = "C", "C" = "G", "N" = "N")
  
  # Step 1: Split sequence into individual bases, reverse the order
  reversed_bases <- rev(strsplit(y, NULL)[[1]])
  
  # Step 2: Replace each base with its complement
  complement_bases <- map[reversed_bases]
  
  # Optional: Handle unexpected bases (replace NA with N to avoid broken output)
  complement_bases[is.na(complement_bases)] <- "N"
  
  # Step 3: Merge back into a single string
  result <- paste(complement_bases, collapse = "")
  
  return(result)
}

Even Shorter Version with chartr #

If you want a more concise approach, R's built-in chartr function is made for this kind of character substitution—it's faster and cleaner:

reverse_complement <- function(y) {
  # Reverse the sequence first
  reversed_seq <- paste(rev(strsplit(y, NULL)[[1]]), collapse = "")
  # Replace each base with its complement (chartr ignores characters not in the first string, so N stays N)
  chartr("ATGC", "TACG", reversed_seq)
}

Test It Out #

If you run reverse_complement("ATGCNATGCN"), you'll get the correct reverse complement: "NCTGNCTGTA".

内容的提问来源于stack exchange，提问作者margo