如何将scanf+while输入验证逻辑移至main外独立函数（支持跨文件）？

Let’s get that country selection logic working reliably in a separate function—no more segmentation faults, and it’ll keep looping until the user enters a valid choice. Here’s what went wrong and how to fix it:

Key Issues in Your Original Code #

1. Uninitialized/Invalid Memory: Your country variable in main was likely an uninitialized char* (or you passed the wrong pointer to scanf), leading to writes to invalid memory (the root cause of the segfault).
2. Incorrect scanf Parameter: In testing_function, you used &country (a pointer to a pointer) with %s, but scanf expects a direct pointer to a character array.
3. Returning Risky Pointers: Returning a pointer to a local variable (if you’d used one) would create a dangling pointer, but even with a passed pointer, your setup didn’t properly modify the original input buffer.

Fixed Single-File Implementation #

This version uses a character array for safe memory storage, fixes the scanf call, and keeps the validation logic in a reusable function:

#include <stdio.h>
#include <string.h>

// Helper function to convert string to lowercase
void case_change(char *str) {
    while (*str) {
        if (*str >= 'A' && *str <= 'Z') {
            *str += 32; // Convert uppercase to lowercase
        }
        str++;
    }
}

// Reusable validation function: modifies the input buffer directly
void get_valid_country(char *country) {
    // Normalize initial input to lowercase for consistent comparison
    case_change(country);
    
    // Loop until valid input is received
    while (strcmp(country, "australia") != 0 && strcmp(country, "japan") != 0) {
        printf("Invalid choice! Please select only Australia or Japan: ");
        // Pass the array pointer directly (no & needed)
        scanf("%49s", country); // Limit input to 49 chars to avoid buffer overflow
        case_change(country);
    }
}

int main() {
    // Allocate a fixed-size array to store input (safe stack memory)
    char country[50];
    
    printf("Please select only Australia or Japan: ");
    scanf("%49s", country);
    
    // Run validation logic
    get_valid_country(country);
    
    // Use the validated country string for further processing
    printf("The country you have selected is %s\n", country);
    return 0;
}

If You Want to Split Into Separate Files #

To move the logic to another .c file (for better organization), follow this structure:

country_utils.h (Header file)

#ifndef COUNTRY_UTILS_H
#define COUNTRY_UTILS_H

// Function declarations
void case_change(char *str);
void get_valid_country(char *country);

#endif

country_utils.c (Implementation file)

#include <stdio.h>
#include <string.h>
#include "country_utils.h"

void case_change(char *str) {
    while (*str) {
        if (*str >= 'A' && *str <= 'Z') {
            *str += 32;
        }
        str++;
    }
}

void get_valid_country(char *country) {
    case_change(country);
    while (strcmp(country, "australia") != 0 && strcmp(country, "japan") != 0) {
        printf("Invalid choice! Please select only Australia or Japan: ");
        scanf("%49s", country);
        case_change(country);
    }
}

main.c

#include <stdio.h>
#include "country_utils.h"

int main() {
    char country[50];
    
    printf("Please select only Australia or Japan: ");
    scanf("%49s", country);
    
    get_valid_country(country);
    
    printf("The country you have selected is %s\n", country);
    return 0;
}

Compile with: gcc main.c country_utils.c -o country_selector

Key Improvements #

• Safe Memory Handling: Using a fixed-size char array ensures scanf writes to valid stack memory, eliminating segfaults.
• Input Limiting: %49s prevents buffer overflow if the user enters too long a string.
• Case Insensitivity: Converting input to lowercase lets users enter "AUSTRALIA", "japan", or mixed cases and still be validated correctly.
• Reusable Logic: The get_valid_country function can be called anywhere in your code, or even in other projects, without rewriting the validation loop.

内容的提问来源于stack exchange，提问作者iLikePizza