Rails 5中创建Account时如何触发User的激活邮件发送？

Hey there! Let's work through this problem together. The core issue here is that your user activation email logic lives only in the UserController's create action, so when you create a user alongside an account via the AccountsController, that code never runs. Here are a few clean ways to fix this:

1. Manually Call the Activation Email in AccountsController #

The quickest fix is to explicitly trigger the email send right after you create the user in your AccountsController. This works if you're building the user directly with the account (either via nested attributes or a separate create step).

Example code for app/controllers/accounts_controller.rb:

def create
  @account = Account.new(account_params)
  
  if @account.save
    # If you're using nested attributes for users:
    @user = @account.users.first 
    # Or if you're creating the user separately:
    # @user = User.create!(user_params.merge(account: @account))
    
    # Trigger the activation email here
    @user.send_activation_email
    
    redirect_to account_dashboard_path, notice: "Account and user created successfully!"
  else
    render :new
  end
end

Just make sure the user is successfully saved before calling send_activation_email—otherwise you'll run into errors.

2. Move Activation Logic to a User Model Callback #

For a more maintainable solution, shift the email send logic into the User model itself using an after_create callback. This way, any time a user is created (no matter which controller does it), the activation email will automatically send.

Update app/models/user.rb:

after_create :send_activation_email, unless: :activation_sent?

def send_activation_email
  UserMailer.account_activation(self).deliver_now
  update_attribute(:activation_sent_at, Time.zone.now)
end

# Add this helper method to prevent duplicate emails
def activation_sent?
  activation_sent_at.present?
end

Then, don't forget to remove the @user.send_activation_email line from your UserController's create action—otherwise you'll end up sending two emails for the signup flow!

3. Extract Logic to a Reusable Service Class #

If you want to keep your controllers lean and avoid duplicating logic, create a service class that handles user creation + activation. This is great for larger apps where you might need this logic in multiple places.

Create app/services/user_creation_service.rb:

class UserCreationService
  def self.call(user_params, account = nil)
    user = User.new(user_params)
    user.account = account if account
    
    ActiveRecord::Base.transaction do
      user.save!
      user.send_activation_email
    end
    
    user
  rescue ActiveRecord::RecordInvalid => e
    user
  end
end

Then update both controllers to use this service:

UserController: #

def create
  @user = UserCreationService.call(user_params)
  
  if @user.persisted?
    redirect_to login_path, notice: "Please check your email to activate your account."
  else
    render :new
  end
end

AccountsController: #

def create
  @account = Account.new(account_params)
  
  if @account.save
    @user = UserCreationService.call(user_params, @account)
    
    if @user.persisted?
      redirect_to account_dashboard_path, notice: "Account created! Check your email to activate your user."
    else
      # Rollback the account if user creation fails
      @account.destroy
      render :new
    end
  else
    render :new
  end
end

This approach keeps your business logic centralized and makes it easy to update later.

内容的提问来源于stack exchange，提问作者Charles Smith