如何结合Read-Host、输入验证与TRAP实现PowerShell脚本变量保留

Hey there! Let's tackle this problem step by step. The core issue you're facing is variable retention when combining Read-Host, input validation, and error handling (either with trap or modern try/catch). Let's break down why this happens and how to fix it, plus a more maintainable approach for your script.

First, a quick heads-up: trap is a legacy error handling mechanism in PowerShell—it’s global by default and can cause scope-related issues with variables. Modern PowerShell favors try/catch blocks because they’re targeted, easier to read, and far less likely to cause variable loss. Let’s build a solution around that, since it’ll solve your variable problem naturally.

Step 1: Encapsulate Input Validation in Reusable Functions #

Instead of mixing validation directly with error handling, create separate functions to get and validate the computer name and OU code. This keeps your logic clean and ensures variables are properly returned once validated.

function Get-ValidComputerName {
    do {
        $inputName = Read-Host "Enter new computer name (8-15 characters)"
        # Validate length requirement
        if ($inputName.Length -lt 8 -or $inputName.Length -gt 15) {
            Write-Warning "Oops! Computer name needs to be between 8 and 15 characters. Try again."
            $isValid = $false
        } else {
            $isValid = $true
        }
    } while (-not $isValid)
    return $inputName
}

function Get-ValidOUCode {
    # List your allowed 2-letter OU codes here
    $allowedOUCodes = @("NY", "LA", "CH", "TX")
    do {
        $inputCode = Read-Host "Enter remote office OU code (2 letters)"
        # Validate length and allowed values
        if ($inputCode.Length -ne 2 -or $allowedOUCodes -notcontains $inputCode) {
            Write-Warning "Invalid OU code! Must be one of: $($allowedOUCodes -join ', '). Try again."
            $isValid = $false
        } else {
            $isValid = $true
        }
    } while (-not $isValid)
    # Return the full OU path (customize this to match your domain structure)
    return "OU=$inputCode,DC=yourdomain,DC=com"
}

Step 2: Main Script with Try/Catch Error Handling #

Now, use these functions to get validated inputs, then run your Add-Computer command inside a try/catch block. Variables will be retained because they’re defined in the script’s main scope, not inside error-handling blocks that might alter scope.

# Set your domain name here
$DomainToJoin = "yourdomain.com"

# Get validated inputs (variables will hold correct values here)
$WS_NewName = Get-ValidComputerName
$LocDN = Get-ValidOUCode

try {
    # Run the core domain join command with -ErrorAction Stop to trigger catch
    Add-Computer -DomainName $DomainToJoin -OUPath $LocDN -NewName $WS_NewName -Restart -ErrorAction Stop
    Write-Host "Success! The computer has joined the domain and will restart shortly." -ForegroundColor Green
} catch {
    Write-Error "Domain join failed: $_"
    # Optional: Add logging or cleanup steps here if needed
}

Why This Fixes Your Variable Loss Issue #

• Function Scope: Each validation function returns the validated value directly to your main script variables—no scope leakage or overwriting.
• Targeted Error Handling: try/catch only acts on errors from the Add-Computer command, not your input validation loops. Your $WS_NewName and LocDN variables remain intact even if the domain join fails.
• User-Friendly Validation: The do-while loops ensure users can correct their input without restarting the script.

If You Must Use trap (Not Recommended) #

If you need to stick with trap for some reason, you’ll need to explicitly use script-level variables (prefix with $script:) to prevent scope loss. For example:

# Declare variables at script scope
$script:WS_NewName = $null
$script:LocDN = $null

trap {
    Write-Error "Error occurred: $_"
    continue # or break, depending on your needs
}

# Validation logic using $script: variables
do {
    $script:WS_NewName = Read-Host "Enter computer name"
    if ($script:WS_NewName.Length -notmatch '^.{8,15}$') {
        Write-Warning "Invalid length"
    }
} while ($script:WS_NewName.Length -notmatch '^.{8,15}$')

# ... repeat for OU code ...

Add-Computer -DomainName $DomainToJoin -OUPath $script:LocDN -NewName $script:WS_NewName -Restart

But again, try/catch is the cleaner, more maintainable approach for modern PowerShell.

内容的提问来源于stack exchange，提问作者Jee