Android聊天程序：父线程调用子线程sendLine方法失败求助

Hey there! Let's figure out why your send button can't call the sendLine method in your ChatThread properly. Based on the code snippets you shared, here are the most common fixes to get this working:

1. Verify Your ChatThread Instance is Valid #

First, make sure your chatThread object is properly initialized and still alive when the send button is clicked. It's easy to accidentally have a null instance or a thread that's already terminated.

Update your send method with checks to avoid null pointers:

public void send(View view) {
    // Check if the thread exists and is running
    if (chatThread != null && chatThread.isAlive()) {
        String message = userInput.getText().toString().trim();
        if (!message.isEmpty()) {
            chatThread.sendLine(message);
            userInput.setText(""); // Clear input after sending
        }
    } else {
        // Notify the user the chat connection isn't ready
        Toast.makeText(this, "Chat thread isn't running!", Toast.LENGTH_SHORT).show();
    }
}

Also, double-check where you initialize and start chatThread (e.g., in your Activity's onCreate):

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.your_layout);
    
    // Initialize and start the thread BEFORE the send button is clicked
    chatThread = new ChatThread();
    chatThread.start();
}

2. Ensure the Output Stream is Fully Initialized #

A common issue is calling sendLine before the to_server PrintWriter is set up in the ChatThread's run method. The thread's run method runs asynchronously, so the stream might not be ready yet when the user clicks send.

Add readiness checks in your ChatThread:

public class ChatThread extends Thread {
    private PrintWriter to_server;
    private boolean isStreamReady = false;

    @Override
    public void run() {
        try {
            // Replace with your server IP and port
            Socket socket = new Socket("your_server_address", 1234);
            to_server = new PrintWriter(socket.getOutputStream(), true);
            isStreamReady = true; // Mark stream as ready once initialized
            
            // Rest of your communication logic (reading from server, etc.)
        } catch (IOException e) {
            e.printStackTrace();
            isStreamReady = false;
        }
    }

    public void sendLine(String line) {
        // Only send if the stream is ready
        if (isStreamReady && to_server != null) {
            to_server.println(line);
        } else {
            Log.e("ChatThread", "Can't send message: Output stream not ready!");
            // Optionally cache the message to send later when the stream is ready
        }
    }
}

3. Add Exception Handling to Catch Hidden Errors #

Your current code doesn't handle exceptions, so if something goes wrong (like a null stream or broken connection), you won't see why the send failed. Wrap your send logic in a try-catch block to debug:

public void send(View view) {
    try {
        if (chatThread != null && chatThread.isAlive()) {
            String message = userInput.getText().toString().trim();
            if (!message.isEmpty()) {
                chatThread.sendLine(message);
                userInput.setText("");
            }
        } else {
            Toast.makeText(this, "Chat not connected!", Toast.LENGTH_SHORT).show();
        }
    } catch (Exception e) {
        e.printStackTrace();
        Toast.makeText(this, "Send failed: " + e.getMessage(), Toast.LENGTH_LONG).show();
    }
}

4. Add Thread Safety (Optional but Recommended) #

If there's any chance multiple threads might call sendLine (e.g., background updates), add synchronization to prevent race conditions:

public synchronized void sendLine(String line) {
    if (isStreamReady && to_server != null) {
        to_server.println(line);
    }
}

Start with these steps—9 times out of 10, the issue is either a null chatThread instance or the output stream not being ready when you try to send. The exception handling will help you pinpoint exactly what's going wrong if the problem persists.

内容的提问来源于stack exchange，提问作者Nungwe