PHP字符串存储购物车删改异常及优化方案咨询

Hey there! Let's tackle your shopping cart problems step by step—first fixing the immediate session and loading issues, then refactoring to a far more maintainable implementation.

Immediate Fixes: Session Reset & First-Load Blank Page #

Why the first load fails #

When a user visits mycart.php for the first time, $_SESSION['bookstrings'] doesn't exist yet. Calling strlen() on an undefined variable throws a warning that can break page rendering. We need to initialize session variables before using them.

Why the session resets #

Most likely, your redirect.php isn't calling session_start() before modifying the session, or you're outputting content (like HTML or whitespace) before starting the session. All pages that touch sessions must call session_start() before any output.

Fixed mycart.php snippet

<?php
session_start();
// Initialize session variables to avoid errors on first load
if (!isset($_SESSION['bookstrings'])) {
    $_SESSION['bookstrings'] = '';
}
// If you're using $_SESSION['cart'], initialize it too
if (!isset($_SESSION['cart'])) {
    $_SESSION['cart'] = '';
}

$numbooks = strlen($_SESSION['bookstrings']) / 3;
echo "You have " . $numbooks . " books in your Cart.";
echo $_SESSION['bookstrings'];
echo "<br><br>";
include '/redirect.php';
?>

Fixed redirect.php for cancel functionality

<?php
session_start(); // Critical: start session before any changes
if (isset($_GET['cancel'])) {
    $cancelPos = (int)$_GET['cancel'] * 3;
    // Validate the position to avoid invalid string operations
    if ($cancelPos >= 0 && $cancelPos < strlen($_SESSION['bookstrings'])) {
        $_SESSION['bookstrings'] = substr($_SESSION['bookstrings'], 0, $cancelPos) . substr($_SESSION['bookstrings'], $cancelPos + 3);
    }
}
// Redirect back with header() and exit to stop further execution
header("Location: mycart.php");
exit;
?>

Better Shopping Cart Implementation: Ditch Strings for Arrays #

Storing product IDs in a string is error-prone (easy to miscalculate positions, hard to scale). Using PHP arrays will make your code cleaner, more flexible, and easier to debug. Here's a full refactor:

1. Add to Cart (e.g., add_to_cart.php) #

<?php
session_start();
// Initialize cart array if it doesn't exist
if (!isset($_SESSION['cart'])) {
    $_SESSION['cart'] = [];
}

// Get product ID from request (adjust based on how you pass it)
$productId = $_GET['product_id']; // e.g., "011"
// Add to cart (add a check here if you want to prevent duplicates)
$_SESSION['cart'][] = $productId;

header("Location: mycart.php");
exit;
?>

2. Cart Display Page (mycart.php) #

<?php
session_start();
if (!isset($_SESSION['cart'])) {
    $_SESSION['cart'] = [];
}

$numItems = count($_SESSION['cart']);
echo "You have " . $numItems . " items in your Cart.<br><br>";

// Product mapping: way better than repeated str_replace!
$productLookup = [
    "011" => "55USD New Traditions and Encounters",
    "031" => "XXUSD Example Book 1",
    "181" => "XXUSD Example Book 2",
    "083" => "XXUSD Example Book 3"
];

// Loop through cart to display items and cancel links
foreach ($_SESSION['cart'] as $index => $productId) {
    $productName = $productLookup[$productId] ?? "Unknown Product ($productId)";
    echo ($index + 1) . ". " . $productName;
    echo ' <a href="cancel_item.php?index=' . $index . '">Cancel</a><br>';
}
?>

3. Cancel Item (cancel_item.php) #

<?php
session_start();
if (isset($_GET['index']) && isset($_SESSION['cart'][$_GET['index']])) {
    // Remove the item at the specified index
    array_splice($_SESSION['cart'], (int)$_GET['index'], 1);
}
header("Location: mycart.php");
exit;
?>

Why Arrays Are Better #

• Readability: You can immediately see what's in the cart instead of parsing a string.
• Ease of Use: Adding/removing items uses built-in array functions (array_push, array_splice) instead of manual string slicing.
• Scalability: Later, you can easily add quantities, prices, or product details by using associative arrays, e.g.:

  $_SESSION['cart'][] = [
      'id' => '011',
      'name' => '55USD New Traditions and Encounters',
      'price' => 55,
      'quantity' => 1
  ];
  

Extra Tips #

• Encapsulate Logic: Move cart functions (add, remove, get items) into a separate file like cart_helpers.php to keep your code organized.
• Prevent Duplicates: If you don't want users adding the same item multiple times, check if the product ID already exists in the cart before adding.
• Validate Input: Always sanitize and validate user input (like the cancel index) to avoid errors or malicious requests.

内容的提问来源于stack exchange，提问作者Kai