Swift中textLabel文本追加失效：新增评论后显示异常咨询

Hey there, let's break down why your text label isn't updating correctly after adding new reviews, and fix it step by step. The core issues here relate to cell reuse and asynchronous request race conditions in your ReviewCell implementation.

Key Problems in Your Current Code #

1. Unreset Cell State on Reuse: Your prepareForReuse() only prints the text label but doesn't reset it. When cells are reused, old text or incomplete asynchronous requests can interfere with new data.
2. Asynchronous Request Race Conditions: The calls to fetch user and game data run in parallel. There's no guarantee which will finish first, so your append() call might try to add text to an empty or stale label.
3. Unsafe Force Unwrapping: Using ! for userId and gameId can cause crashes if those values are missing, and makes the code less reliable.

Modified Solution Code #

First, Fix prepareForReuse() to Reset Cell State #

override func prepareForReuse() {
    super.prepareForReuse()
    // Reset all cell content to avoid stale data
    textLabel?.text = nil
    detailTextLabel?.text = "Tap to see more"
    gameCoverView.image = nil
    
    // Optional: Cancel any pending Firebase observers to prevent memory leaks
    // (Add these properties to your ReviewCell class first:)
    // private var userObserverHandle: DatabaseHandle?
    // private var gameObserverHandle: DatabaseHandle?
    // if let handle = userObserverHandle {
    //     Database.database().reference().removeObserver(withHandle: handle)
    // }
    // if let handle = gameObserverHandle {
    //     Database.database().reference().removeObserver(withHandle: handle)
    // }
}

Refactor the review Did-Set Logic to Avoid Race Conditions #

Instead of appending text incrementally, collect all required data first, then set the full text label once both asynchronous requests complete:

var review: Review? {
    didSet {
        guard let review = review else { return }
        
        // Determine rating text first
        let rateText: String
        switch review.rate ?? -1 {
        case 0: rateText = "It's awful"
        case 1: rateText = "Nothing special"
        case 2: rateText = "Meh"
        case 3: rateText = "Maybe I'll play it if I don't have Internet"
        case 4: rateText = "IT'S AWESOME"
        default: rateText = "none"
        }
        
        // Store data from async requests until both are ready
        var username: String?
        var gameName: String?
        
        // Fetch user data safely
        guard let userId = review.userId else { return }
        let userRef = Database.database().reference().child("users").child(userId)
        userRef.observeSingleEvent(of: .value) { [weak self] snapshot in
            guard let self = self, let userDict = snapshot.value as? [String: AnyObject] else { return }
            username = userDict["username"] as? String
            self.updateTextLabel(username: username, gameName: gameName, rateText: rateText)
        }
        
        // Fetch game data safely
        guard let gameId = review.gameId else { return }
        let gameRef = Database.database().reference().child("games").child(gameId)
        gameRef.observeSingleEvent(of: .value) { [weak self] snapshot in
            guard let self = self, let gameDict = snapshot.value as? [String: AnyObject] else { return }
            gameName = gameDict["name"] as? String
            
            // Set game cover image
            if let coverUrl = gameDict["gameCover"] as? String {
                self.gameCoverView.loadImageWithCacheFromUrlString(urlString: coverUrl)
            }
            
            self.updateTextLabel(username: username, gameName: gameName, rateText: rateText)
        }
    }
}

// Helper method to build and set the full text label only when all data is ready
private func updateTextLabel(username: String?, gameName: String?, rateText: String) {
    guard let username = username, let gameName = gameName else { return }
    textLabel?.text = "\(username) rated \(gameName) as \"\(rateText)\""
}

Why This Works #

• No Race Conditions: The updateTextLabel method only sets the text when both the username and game name are available, so you never have partial or out-of-order text.
• Clean Cell Reuse: prepareForReuse() ensures every reused cell starts with empty state, eliminating stale data from previous uses.
• Safer Optional Handling: We use optional binding instead of force unwrapping, making the code more crash-resistant.

内容的提问来源于stack exchange，提问作者Vladimir Danoski