PowerShell审计脚本循环异常：站点列表重复执行问题排查

Hey Nate, let's dig into why your PowerShell script's ForEach loop is repeating the entire site list instead of terminating properly. I’ve run into this exact kind of issue a handful of times, so here are the most likely culprits and targeted fixes tailored to your audit workflow:

1. You’re modifying the original collection mid-loop #

PowerShell’s foreach loop enumerates collections dynamically. If your script modifies the original $SiteTML CSV data (like adding/removing entries) while the loop is running, it’ll re-enumerate the entire updated collection—making it look like the loop is repeating.

Fix: Convert your CSV data to a static array first, so the loop uses a fixed set of items that won’t change during iteration:

# Store CSV data in a static array to avoid dynamic re-enumeration
$siteList = @($SiteTML)

# Now loop through the static array instead of $SiteTML
foreach ($site in $siteList) {
    # Your popup confirmation logic here
}

2. Loop control keywords are misused #

If you’re using continue when you mean break, or placing control keywords inside nested scopes (like popup event handlers), you won’t exit the loop correctly:

• continue skips only the current iteration, not the entire loop.
• If you’re using WinForms popups, putting break inside a button click callback won’t affect the parent foreach loop (it’s in a different scope).

Fix: Capture the popup’s return value first, then use break in the main loop scope to terminate early:

$failedSites = @()

foreach ($site in $siteList) {
    $result = [System.Windows.Forms.MessageBox]::Show(
        "完成站点 $($site.SiteName) 的审计了吗?", 
        "审计确认", 
        [System.Windows.Forms.MessageBoxButtons]::YesNoCancel
    )

    switch ($result) {
        "Yes" {
            # Mark as complete, move to next site
            continue
        }
        "No" {
            # Capture error and send email
            $errorMsg = Read-Host "请输入错误信息"
            # Add your email sending logic here...
            $failedSites += $site
        }
        "Cancel" {
            # Terminate the entire loop immediately
            break
        }
    }
}

3. The entire loop is wrapped in an unintended repeating block #

Double-check if your foreach loop is nested inside a do-while or while loop that has no proper exit condition. For example, if your shift/auditor selection logic runs in a loop that always evaluates to $true, it’ll re-run the entire site audit sequence over and over.

Fix: Add a clear exit flag to control the outer loop:

$auditSessionActive = $true

while ($auditSessionActive) {
    # Select shift and auditor logic
    $selectedAuditor = Read-Host "输入审计员姓名"
    $selectedShift = Read-Host "输入班次"

    # Filter sites for the selected auditor/shift
    $targetSites = $siteList | Where-Object { 
        $_.Auditor -eq $selectedAuditor -and $_.Shift -eq $selectedShift 
    }

    # Run site audit loop
    foreach ($site in $targetSites) {
        # Popup logic from above...
    }

    # Ask if user wants to start a new audit session
    $continueChoice = [System.Windows.Forms.MessageBox]::Show(
        "是否需要重新审计其他班次/审计员?",
        "继续审计?",
        [System.Windows.Forms.MessageBoxButtons]::YesNo
    )

    if ($continueChoice -eq "No") {
        $auditSessionActive = $false
    }
}

4. Filtering logic is returning duplicate or full site lists #

If your shift/auditor filter isn’t working correctly, you might be looping through the entire $SiteTML list every time instead of just the auditor’s assigned sites. This can make it seem like the loop is repeating when it’s actually processing the full set each time.

Fix: Validate your filtered list before looping:

$targetSites = $siteList | Where-Object { 
    $_.Auditor -eq $selectedAuditor -and $_.Shift -eq $selectedShift 
}

# Verify the filtered sites
Write-Host "准备审计以下站点：`n$($targetSites.SiteName -join "`n")"
if ($targetSites.Count -eq 0) {
    [System.Windows.Forms.MessageBox]::Show("未找到该审计员/班次的站点！", "错误", [System.Windows.Forms.MessageBoxButtons]::OK, [System.Windows.Forms.MessageBoxIcon]::Error)
    continue # Skip to re-select auditor/shift
}

Bonus: Final failed sites summary popup #

Here’s a clean way to show the summary of un-audited sites once the loop finishes:

if ($failedSites.Count -gt 0) {
    $summaryMsg = "未完成审计的站点：`n`n$($failedSites.SiteName -join "`n")"
    [System.Windows.Forms.MessageBox]::Show(
        $summaryMsg,
        "审计故障汇总",
        [System.Windows.Forms.MessageBoxButtons]::OK,
        [System.Windows.Forms.MessageBoxIcon]::Warning
    )
} else {
    [System.Windows.Forms.MessageBox]::Show(
        "所有站点审计完成！",
        "审计完成",
        [System.Windows.Forms.MessageBoxButtons]::OK,
        [System.Windows.Forms.MessageBoxIcon]::Information
    )
}

内容的提问来源于stack exchange，提问作者Nate