如何在RSpec中正确Mock对象？S3下载URL生成器测试问题

我来帮你排查这个RSpec测试的问题——你遇到的错误其实是几个常见的Mock使用误区加上参数不匹配导致的，咱们一步步拆解解决。

首先先还原你的代码场景：

你的S3DownloadUrlGenerator类 #

class S3DownloadUrlGenerator
  def initialize(filename)
    @filename = filename
  end

  def presigned_url
    signer = Aws::S3::Presigner.new(client: s3)
    signer.presigned_url(
      :get_object,
      bucket: "my-bucket",
      key: filename,
      response_content_disposition: "attachment",
    )
  end

  private

  def s3
    @s3 ||= Aws::S3::Client.new(
      region: "my-region", # 注意：原代码这里少了闭合引号，实际运行会报错，先修复
      http_open_timeout: 5,
      http_read_timeout: 25,
    )
  end

  attr_reader :filename
end

你的测试代码 #

describe S3DownloadUrlGenerator do
  before do
    allow(Aws::S3::Client).to receive(:new) { s3_client }
  end

  let(:s3_client) { spy("s3 client") }
  let(:presigner) { spy("s3 presigner") }

  it "generates download URL for a file" do
    expect(Aws::S3::Presigner).to receive(:new).with(client: s3_client).and_return(presigner)
    expect(presigner).to receive(:presigned_url).with(
      :get_object,
      bucket: "my-test-bucket",
      key: "test_file.txt",
      response_content_disposition: "attachment",
    ).and_return("https://www.example.com")

    expect(described_class.new("Test_file.txt").presigned_url).to eq("https://www.example.com")
  end
end

你遇到的错误 #

Failure/Error: expect(described_class.new("Test_file.txt").presigned_url).to eq("https://www.example.com")
expected: "https://www.example.com"
got: #<Double "s3 presigner"> (compared using ==)

问题根源分析 #

1. Spy的返回值逻辑问题：你用spy("s3 presigner")创建的间谍对象，只有当它的方法调用完全匹配你设置的expect条件时，才会返回你指定的URL。如果参数不匹配，间谍会默认返回自身，这就是你看到#<Double "s3 presigner">的核心原因。
2. Bucket名称不匹配：你的类里硬编码的bucket是"my-bucket"，但测试里期望的是"my-test-bucket"，参数不匹配导致presigned_url的接收期望从未触发。
3. 文件名大小写不匹配：你初始化类时用的是"Test_file.txt"，但测试期望的key是"test_file.txt"，而你的类直接返回原文件名，大小写不一致导致参数匹配失败。
4. 原类的语法错误：s3方法里的region参数少了闭合引号，虽然测试中被Mock屏蔽了，但实际运行会报错，必须修复。

修复后的测试代码 #

describe S3DownloadUrlGenerator do
  before do
    # 使用instance_double更严格，会检查真实类是否存在对应方法
    allow(Aws::S3::Client).to receive(:new).and_return(s3_client)
  end

  let(:s3_client) { instance_double(Aws::S3::Client) }
  let(:presigner) { instance_double(Aws::S3::Presigner) }

  it "generates download URL for a file" do
    # 验证Presigner的初始化逻辑
    expect(Aws::S3::Presigner).to receive(:new).with(client: s3_client).and_return(presigner)
    
    # 严格匹配类中实际使用的参数：bucket是"my-bucket"，key是传入的原文件名
    expect(presigner).to receive(:presigned_url).with(
      :get_object,
      bucket: "my-bucket",
      key: "Test_file.txt",
      response_content_disposition: "attachment"
    ).and_return("https://www.example.com")

    # 执行测试并验证结果
    generator = described_class.new("Test_file.txt")
    expect(generator.presigned_url).to eq("https://www.example.com")
  end
end

额外优化建议 #

为了让代码更灵活、更易测试，建议把硬编码的配置抽成可配置参数：

class S3DownloadUrlGenerator
  def initialize(filename, bucket: "my-bucket", region: "my-region")
    @filename = filename
    @bucket = bucket
    @region = region
  end

  def presigned_url
    signer = Aws::S3::Presigner.new(client: s3)
    signer.presigned_url(
      :get_object,
      bucket: @bucket,
      key: filename,
      response_content_disposition: "attachment",
    )
  end

  private

  def s3
    @s3 ||= Aws::S3::Client.new(
      region: @region,
      http_open_timeout: 5,
      http_read_timeout: 25,
    )
  end

  attr_reader :filename, :bucket
end

这样测试时可以轻松传入测试用配置：

# 测试中修改初始化逻辑
generator = described_class.new("Test_file.txt", bucket: "my-test-bucket")
# 对应的期望参数也改成"my-test-bucket"即可

内容的提问来源于stack exchange，提问作者jedi