Rails关联架构咨询：实现Building-Flat-Room层级查询

Hey there! Let's fix up your associations so that building.find(1).flats.find(1).rooms works exactly as you want it to. Here's what's off and how to correct it step by step:

1. Fix the Model Associations #

Your current models have a small syntax error and some optional tweaks for consistency:

class Building < ApplicationRecord
  has_many :flats
  # Fixed the `through` association to use plural :flats (matches the has_many above)
  has_many :rooms, through: :flats
end

class Flat < ApplicationRecord
  belongs_to :building
  # Added `dependent: :destroy` as a best practice—deletes rooms when their flat is deleted
  has_many :rooms, dependent: :destroy
end

class Room < ApplicationRecord
  belongs_to :flat
  # Optional: If you don't need direct access to building from room, remove this line
  # It creates redundancy since you can always call `room.flat.building`
  belongs_to :building, optional: true
end

Key Fixes: #

• The Building model's through: :flat was singular; it needs to match the plural has_many :flats association.
• The Flat model's has_many :rooms gets a dependent: :destroy to clean up associated rooms when a flat is removed.
• The Room model's direct belongs_to :building is optional—keeping it can lead to data inconsistency (e.g., a room's building_id not matching its flat's building_id), so only keep it if you have a specific use case.

2. Clean Up the Database Schema #

Your schema has a redundant field and can be optimized for correct relationships:

# Buildings table stays as-is—no issues here
create_table "buildings", force: :cascade do |t|
  t.string "name"
  # Add other fields as needed
end

# Flats table: Remove the unnecessary `room_id` field (a flat has many rooms, not one)
create_table "flats", force: :cascade do |t|
  t.string "number"
  t.bigint "building_id"
  t.index ["building_id"], name: "index_flats_on_building_id"
end

# Rooms table: Optional—remove `building_id` if you don't need direct room-to-building association
create_table "rooms", force: :cascade do |t|
  t.string "number"
  t.bigint "flat_id"
  t.index ["flat_id"], name: "index_rooms_on_flat_id"
end

# Add foreign key constraints for database-level data integrity (highly recommended)
add_foreign_key "flats", "buildings"
add_foreign_key "rooms", "flats"
# Uncomment below only if you kept the direct room-building association
# add_foreign_key "rooms", "buildings"

Key Fixes: #

• The flats table's room_id field is invalid for a one-to-many relationship between flats and rooms—delete it immediately.
• Adding foreign keys ensures you can't create a flat with a non-existent building ID, or a room with a non-existent flat ID.

3. Test Your Query #

With the fixes above, your desired query will work perfectly:

# Fetch building 1 → fetch its flat 1 → get all rooms in that flat
building.find(1).flats.find(1).rooms

You can also use these convenient queries now:

• building.find(1).rooms to get all rooms in the entire building (thanks to the through: :flats association)
• flat.find(1).building to get the building a flat belongs to
• room.find(1).flat to get the flat a room belongs to

内容的提问来源于stack exchange，提问作者foliwe83