注入式Web3环境下Solidity转账函数无法正常工作

Let's break down what's happening here and fix the issues step by step:

First: The MetaMask display confusion is normal #

When you see MetaMask showing the transaction is sending 0 ETH to the contract address, that's not a bug—it's how transaction metadata works:

• You're initiating a transaction to call the contract's transferEtherTo function, not sending ETH directly to the target address. The transaction itself doesn't need to include ETH (hence the 0 amount shown), and its direct recipient is the contract.
• The actual transfer of 5 ETH from the contract to _to happens internally when the contract executes the function. MetaMask only shows the details of the transaction you're signing, not the subsequent internal contract logic.

Why the "out of gas" error in injected Web3 (but not JS VM)? #

Remix's JavaScript VM automatically assigns a very generous gas limit to test transactions, which hides gas-related issues. MetaMask uses more conservative default gas limits, which can trigger failures in specific scenarios:

1. Insufficient gas limit set by MetaMask #

Even though transfer() only requires 2300 gas for external accounts, MetaMask's default gas limit might be too low (or adjusted down accidentally) to cover the full execution overhead of the transaction.

• Fix: When confirming the transaction in MetaMask, manually increase the gas limit (try setting it to 100,000 as a safe starting point) and re-submit.

2. Recipient is a contract with gas-heavy fallback function #

If your _to address is a contract (not an external user account), the transfer() method only sends 2300 gas to the recipient's fallback function. If that fallback function needs more gas (e.g., to write to storage or run logic), it will throw an "out of gas" error.

• In the JavaScript VM, you might have tested with an external account (which has no fallback function), so this issue didn't surface.
• Fix: Replace transfer() with call() to specify a higher gas limit (note: this requires adding error handling):

  function transferEtherTo(address _to) payable public {
      (bool success, ) = _to.call{value: address(this).balance}("");
      require(success, "Transfer failed");
  }
  

3. Incorrect function parameter input #

Double-check that you're passing a valid _to address when calling the function in injected Web3 mode. An invalid or empty address can cause unexpected contract execution that drains gas unnecessarily.

Critical Security Note #

Your current function allows any user to drain all ETH from the contract—this is a massive vulnerability. Add access control to restrict who can call the function, e.g.:

address public immutable owner;

constructor() {
    owner = msg.sender;
}

function transferEtherTo(address _to) payable public onlyOwner {
    _to.transfer(address(this).balance);
}

modifier onlyOwner() {
    require(msg.sender == owner, "Only contract owner can call this");
    _;
}

内容的提问来源于stack exchange，提问作者benjamin852