Rails中ActiveRecord的destroy方法是否会执行失败？是否需添加判断逻辑？

Great question—let’s break this down step by step, like we’re debugging together over a coffee.

First: Does ActiveRecord's destroy Method Ever Fail? #

Absolutely, yes. It’s not a guaranteed success every time. Here are the most common failure scenarios:

• Database constraint blocks: If your Article has associated records (like comments) with a foreign key set to restrict_with_error or restrict_with_exception, deleting the article will throw an error (e.g., ActiveRecord::InvalidForeignKey) instead of removing it.
• Callback aborts: If you have a before_destroy callback that returns false, the entire destroy operation gets stopped cold. For example:

  class Article < ApplicationRecord
    before_destroy :block_deletion_if_published
  
    private
    def block_deletion_if_published
      return false if published? # Stops deletion if the article is live
    end
  

• Rare edge cases: Database connection drops or unexpected runtime errors can also tank the deletion, though these are less common.

A critical note: The destroy method itself returns the record object (not a boolean). To actually check if the deletion succeeded, use destroy? instead—it returns true if the record was deleted, false otherwise.

Second: Should You Add That Check Logic in destroy? #

Your current code needs a few tweaks, plus some best practices to make it solid:

1. Fix the success check first:
   Your if @article.destroy will always evaluate to "truthy" (since it returns the article object), even if deletion failed. Swap it for if @article.destroy? to properly detect success:

   def destroy
     if @article.destroy?
       flash[:success] = 'Article deleted'
       redirect_to articles_path
     else
       flash[:error] = 'Failed to delete the article'
       redirect_to article_path(@article)
     end
   end
   

2. Move permission checks to the before_action:
   Your set_user method is trying to verify the current user is the article’s author, but it’s incomplete. You should block unauthorized users before they even reach the destroy method. Update set_user like this:

   private
   def set_user
     @article = Article.find(params[:id])
     unless current_user.id == @article.author_id
       flash[:error] = "You don't have permission to modify this article"
       redirect_to articles_path and return # Halt execution here
     end
   end
   

   This is cleaner and more secure—unauthorized users never get a chance to attempt deletion.

3. Add specific error handling for database constraints:
   destroy? will return false for foreign key issues, but it won’t tell the user why. To give clearer feedback, wrap the call in a rescue block:

   def destroy
     if @article.destroy?
       flash[:success] = 'Article deleted'
       redirect_to articles_path
     else
       flash[:error] = "Failed to delete the article: #{@article.errors.full_messages.join(', ')}"
       redirect_to article_path(@article)
     rescue ActiveRecord::InvalidForeignKey
       flash[:error] = "Can't delete this article—it has linked comments"
       redirect_to article_path(@article)
     end
   

Final Takeaway #

Adding the success check (when done correctly) is a smart move to handle silent failures. Pair that with proper permission checks in the before_action and targeted exception handling, and you’ll have a robust, user-friendly destroy action.

内容的提问来源于stack exchange，提问作者Rigi