Salesforce新手求助：优化硬编码PDF生成的Apex控制器实现

Hey there! As someone who’s dealt with the frustration of repetitive hardcoding in Apex, I totally get where you’re coming from. Let’s walk through some clean, scalable ways to fix this so you don’t have to duplicate code every time you add a new PDF letter.

1. Use an Enum to Centralize Page References #

This is my go-to approach because it keeps all your PDF-related Visualforce pages in one easy-to-manage spot. No more hunting through multiple methods to update a page name or fix a typo!

First, define an enum in your controller (or a separate utility class if you need to reuse it across controllers):

public enum PdfLetterType {
    GENERAL_EXAMPLE('ltr_one_generalexample'),
    CUSTOMER_WELCOME('ltr_two_customerwelcome'),
    INVOICE_REMINDER('ltr_three_invoicereminder');

    public final String pageName;

    PdfLetterType(String pageName) {
        this.pageName = pageName;
    }
}

Then create a single reusable method that takes the enum as a parameter and handles all the common PDF logic:

public PageReference generatePdf(PdfLetterType letterType) {
    // Dynamically create the page reference using the enum's stored page name
    PageReference pdf = new PageReference('/apex/' + letterType.pageName);
    
    // Add your shared PDF setup here (like passing record IDs, setting headers)
    pdf.getParameters().put('recordId', yourRecordId);
    pdf.setRedirect(true);
    
    return pdf;
}

Now you can replace all your individual saveLetterX methods with simple calls to this one method:

public PageReference saveLetter1() {
    return generatePdf(PdfLetterType.GENERAL_EXAMPLE);
}

public PageReference saveLetter2() {
    return generatePdf(PdfLetterType.CUSTOMER_WELCOME);
}

2. Use Custom Settings for Admin-Friendly Updates #

If you want to let admins add or modify PDF pages without touching code, Custom Settings are perfect.

1. Create a List Custom Setting (e.g., PdfLetterMapping__c) with fields like LetterLabel__c (text for human-readable names) and PageName__c (text for the Visualforce page name).
2. Add entries for each PDF letter (e.g., LetterLabel = "General Example", PageName = "ltr_one_generalexample").

Then your reusable method can fetch the page name dynamically from the setting:

public PageReference generatePdf(String letterLabel) {
    PdfLetterMapping__c mapping = PdfLetterMapping__c.getInstance(letterLabel);
    if(mapping == null) {
        // Handle invalid letter labels (throw an error, return null, etc.)
        ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.ERROR, 'Invalid letter type selected'));
        return null;
    }
    
    PageReference pdf = new PageReference('/apex/' + mapping.PageName__c);
    // Add common PDF logic here
    return pdf;
}

Call it like this:

public PageReference saveLetter1() {
    return generatePdf('General Example');
}

3. Pass Page Names Directly from Visualforce #

If your command buttons are on a Visualforce page, you can eliminate multiple Apex methods entirely by passing the page name as a parameter directly from the button.

In your Visualforce page:

<apex:commandButton value="Download General Example" action="{!generatePdf}" >
    <apex:param name="pageName" value="ltr_one_generalexample" assignTo="{!selectedPageName}" />
</apex:commandButton>

<apex:commandButton value="Download Customer Welcome" action="{!generatePdf}" >
    <apex:param name="pageName" value="ltr_two_customerwelcome" assignTo="{!selectedPageName}" />
</apex:commandButton>

Then in your controller:

public String selectedPageName { get; set; }

public PageReference generatePdf() {
    if(String.isBlank(selectedPageName)) {
        ApexPages.addMessage(new ApexPages.Message(ApexPages.Severity.ERROR, 'No PDF page selected'));
        return null;
    }
    
    PageReference pdf = new PageReference('/apex/' + selectedPageName);
    // Add common PDF setup logic here
    return pdf;
}

Bonus Tip: Add Validation #

Whichever approach you pick, add a quick check to make sure the page exists and is accessible. You can wrap pdf.getContent() in a try-catch block to catch invalid page names, or use user permission checks to ensure the user can access the Visualforce page.

内容的提问来源于stack exchange，提问作者CCC Admin