C++链表程序报错排查：仅首元素可打印问题求助

Hey there! Let's troubleshoot this linked list issue together—it's a super common pitfall when you're getting back into writing linked list code, so don't worry, we'll sort it out quickly.

First, Let's Break Down the Symptom #

You mentioned only the head element prints, and head->next seems empty, but printing existing elements while adding new ones works. That tells us two key things:

• The head node is being initialized correctly
• Either your add() function isn't properly attaching new nodes to the end of the list, or your printAll() has a loop condition bug

Most Likely Causes & Fixes #

1. Your add() Function Isn't Properly Appending Nodes

The #1 mistake here is either:

• Trying to assign the new node to a local pointer that doesn't update the actual list, or
• Stopping your traversal too early (or too late) when finding the end of the list.

Example of a Broken add() Function

This is a common wrong implementation that leads to your exact issue:

void add(int val) {
    Node* newNode = new Node();
    newNode->data = val;
    newNode->next = nullptr;

    if (head == nullptr) {
        head = newNode;
    } else {
        Node* current = head;
        // ❌ Loop runs until current is null (past the last valid node)
        while (current != nullptr) {
            current = current->next;
        }
        // ❌ Assigning to local current doesn't modify the actual list
        current = newNode;
    }
}

Fixed add() Function

This version correctly traverses to the last valid node and attaches the new node to its next pointer:

void add(int val) {
    Node* newNode = new Node(val); // Use a constructor to initialize data/next cleanly
    if (head == nullptr) {
        head = newNode;
        return;
    }
    // ✅ Traverse until we reach the last node (its next is null)
    Node* current = head;
    while (current->next != nullptr) {
        current = current->next;
    }
    // ✅ Attach new node to the end of the list
    current->next = newNode;
}

2. Your printAll() Has a Wrong Loop Condition

Another common issue is a loop that stops before printing all nodes. For example:

void printAll() {
    Node* current = head;
    // ❌ Stops after printing the head (since head->next is null in your case)
    while (current->next != nullptr) {
        cout << current->data << " ";
        current = current->next;
    }
}

Fixed printAll() Function

Use a loop that runs as long as current isn't null to print every node:

void printAll() {
    cout << "List contents: ";
    Node* current = head;
    // ✅ Traverse every node until we hit the end of the list
    while (current != nullptr) {
        cout << current->data << " ";
        current = current->next;
    }
    cout << endl;
}

Full Working Code Example #

Here's a complete, corrected version of your linked list class with these fixes, plus a constructor for Node to avoid initialization bugs:

#include<iostream>
using namespace std;

class Node {
public:
    int data;
    Node* next;
    // Constructor to initialize data and next pointer automatically
    Node(int val = 0) : data(val), next(nullptr) {}
};

class List {
private:
    Node* head;
public:
    List() : head(nullptr) {}

    void add(int val) {
        Node* newNode = new Node(val);
        if (head == nullptr) {
            head = newNode;
            return;
        }
        Node* current = head;
        while (current->next != nullptr) {
            current = current->next;
        }
        current->next = newNode;
    }

    void printAll() {
        cout << "List elements: ";
        Node* current = head;
        while (current != nullptr) {
            cout << current->data << " ";
            current = current->next;
        }
        cout << endl;
    }

    // Don't forget a destructor to clean up memory leaks!
    ~List() {
        Node* current = head;
        while (current != nullptr) {
            Node* temp = current;
            current = current->next;
            delete temp;
        }
        head = nullptr;
    }
};

int main() {
    List myList;
    myList.add(10);
    myList.add(20);
    myList.add(30);
    myList.printAll(); // Should output: List elements: 10 20 30
    return 0;
}

Quick Debug Tips to Verify #

• Add debug prints in your add() function to check the address of current->next after attaching a new node—this will confirm if the new node is being linked properly.
• Print the value of head->next right after adding a second node to see if it's pointing to the new node (instead of null).

内容的提问来源于stack exchange，提问作者Akshay Barpute