基于头文件枚举的玩家切换及井字棋代码优化问题咨询

Hey there, let's work through your three questions about the game.c Tic-Tac-Toe code step by step:

1. Fixing P2_TURN Startup, Turn Alternation with Enums, and Correct Win Status #

Why it starts directly in P2_TURN #

Most likely, your struct game's turn member is initialized to P2_TURN instead of P1_TURN. Double-check your game initialization code—make sure you set p_game_info->turn = P1_TURN when starting a new game.

Implementing turn alternation with enums #

After a valid move is made by a player, you can toggle the turn using a simple ternary operator (cleaner than clunky conditionals for two states):

// After processing a valid move
p_game_info->turn = (p_game_info->turn == P1_TURN) ? P2_TURN : P1_TURN;

This works seamlessly because your enum (like typedef enum { P1_TURN, P2_TURN } turn_state;) uses sequential integer values, so the toggle logic is straightforward.

Correct win status in print_status() #

First, add a winner member to your struct game (or use a separate variable) that gets set when a win condition is met. When checking for a win, set p_game_info->winner to P1 or P2 (or a NO_WIN enum value if no winner exists yet). Then update print_status() like this:

void print_status(struct game* p_game_info) {
    if (p_game_info->winner == P1) {
        printf("*Player 1 wins!*\n");
    } else if (p_game_info->winner == P2) {
        printf("*Player 2 wins!*\n");
    } else if (is_board_full(p_game_info)) { // Add a helper to check for ties
        printf("*It's a tie!*\n");
    } else {
        printf("Player %d's turn\n", (p_game_info->turn == P1_TURN) ? 1 : 2);
    }
}

Make sure you run the win check right after each valid move, before toggling the turn.

2. More Concise Winner Detection #

Instead of writing repetitive if statements for every row, column, and diagonal, define all winning combinations in a 2D array, then loop through each set to check for a win. This cuts down on redundant code and makes maintenance easier:

// Define all 8 winning line combinations (each is 3 board indices)
const int winning_lines[8][3] = {
    {0,1,2}, {3,4,5}, {6,7,8}, // Rows
    {0,3,6}, {1,4,7}, {2,5,8}, // Columns
    {0,4,8}, {2,4,6}            // Diagonals
};

// Helper function to check for a winner
int check_winner(struct game* p_game_info) {
    char* board = p_game_info->board; // Assume your board is a char array (e.g., 'X', 'O', ' ')
    for (int i = 0; i < 8; i++) {
        int a = winning_lines[i][0];
        int b = winning_lines[i][1];
        int c = winning_lines[i][2];
        if (board[a] != ' ' && board[a] == board[b] && board[b] == board[c]) {
            // Return P1 or P2 based on the marker
            return (board[a] == 'X') ? P1 : P2;
        }
    }
    return NO_WIN; // Define this in your enum for no winner
}

Call this function after each move—if it returns anything other than NO_WIN, set your winner member and end the game loop.

3. Replace Switch with Math in process_move() #

Absolutely! Instead of a 9-case switch statement, use integer division and modulus to map 0-8 input to (row, col) coordinates. Since the board is 3x3:

• Row = input / 3 (integer division truncates, so 0-2 → 0, 3-5 →1, 6-8→2)
• Column = input %3 (gives the remainder, so 0,3,6→0; 1,4,7→1; 2,5,8→2)

Here's how to adjust process_move():

void process_move(struct game* p_game_info) {
    int input;
    printf("Enter your move (0-8): ");
    scanf("%d", &input);

    // Validate input is within range and the spot is empty first!
    if (input < 0 || input >8 || p_game_info->board[input] != ' ') {
        printf("Invalid move—try again!\n");
        return;
    }

    int row = input / 3;
    int col = input % 3;

    // Place the player's marker (adjust if your board is 2D instead of 1D)
    p_game_info->board[input] = (p_game_info->turn == P1_TURN) ? 'X' : 'O';
    // For 2D boards: p_game_info->board[row][col] = (p_game_info->turn == P1_TURN) ? 'X' : 'O';
}

This is way cleaner than a long switch and works perfectly for a 3x3 board.

内容的提问来源于stack exchange，提问作者Maciej Kubiniec