技术问题：添加节点后树的根节点为Null且节点未实际插入

Hey there! Let's break down why your tree isn't being built properly, and how to fix it so you get the updated root node with all your nodes added successfully.

The Core Problem in Your Code #

Looking at your main function, there are two key issues that lead to the root staying null and nodes not being added:

• Passing the root pointer by value: When you do btnode* root = tree->get_root_btnode() and pass this root to create_btree, you're passing a copy of the null pointer. In C++, any changes to this pointer inside create_btree only affect the local copy, not the actual root pointer stored inside your btree::tree object. So the tree's internal root never gets updated.
• No validation or proper root handling: You delete the tree right after calling create_btree without checking if the root was actually set, and you never sync the created nodes back to the tree's internal state.

Fix 1: Pass the Root Pointer by Reference #

Assuming you can modify the create_btree function's signature to accept a pointer reference, here's how to adjust your client code:

#include <iostream> // Add this for validation prints

int main () {
    int arr [] = {15, 10, 100, 5, 13, 90, 80, 50, 10, 5, 3};
    int len = sizeof(arr)/sizeof(*arr);
    using namespace btree;

    // Create tree instance
    btree::tree* tree = new btree::tree();
    
    // Pass the tree's root pointer by reference (so changes affect the tree's internal root)
    tree->create_btree(tree->get_root_btnode_ref(), arr, len);
    
    // Get the updated root node
    btree::btnode* root = tree->get_root_btnode();
    
    // Validate the root is set
    if (root != nullptr) {
        std::cout << "Success! Root node value: " << root->value << std::endl;
        // Add tree traversal here if you want to verify all nodes are present
    } else {
        std::cout << "Root is still null - check create_btree implementation!" << std::endl;
    }

    delete tree;
    return 0;
}

For this to work, your btree::tree class needs a method like get_root_btnode_ref() that returns a reference to the internal root pointer:

btnode*& get_root_btnode_ref() {
    return this->root; // Assuming 'root' is a member variable of type btnode*
}

Fix 2: Have create_btree Return the New Root #

If modifying create_btree's signature isn't an option, adjust it to return the newly created root node, then set it explicitly on the tree:

#include <iostream>

int main () {
    int arr [] = {15, 10, 100, 5, 13, 90, 80, 50, 10, 5, 3};
    int len = sizeof(arr)/sizeof(*arr);
    using namespace btree;

    btree::tree* tree = new btree::tree();
    
    // Let create_btree build the tree and return the root
    btree::btnode* root = tree->create_btree(arr, len);
    // Set the root on the tree (assuming a setter exists)
    tree->set_root_btnode(root);
    
    // Validate
    if (root != nullptr) {
        std::cout << "Success! Root node value: " << root->value << std::endl;
    }

    delete tree;
    return 0;
}

Key Takeaways #

• Always make sure modifications to the root pointer inside create_btree propagate back to the tree object—either via pointer references or returning the new root.
• Validate the root state before destroying the tree to confirm your nodes were added correctly.

内容的提问来源于stack exchange，提问作者Amaresh Kumar