Python 2.7中修改特定行时覆盖文件的更优方法咨询

Hey there! Let's break down what's off with your current code and fix it up so you can reliably update a specific line in a file. Your core logic is on the right track, but there are a few critical issues that'll cause errors or even data loss.

Issues in your original code #

• file.open("test.txt") is invalid syntax—you should use Python's built-in open() function, and you're hardcoding "test.txt" instead of using the original file's name.
• You're trying to os.remove(fil) where fil is a file object, not a filename. That'll throw an error.
• Renaming the file by setting m.name = z doesn't actually rename the file on disk; you need os.rename() for that.
• You're not closing file handles properly, which can lead to resource leaks or corrupted files.
• There's no check for invalid line numbers (e.g., if the line number is larger than the number of lines in the file).

Improved implementation (simple version) #

This version uses with statements to automatically handle file closing, validates line numbers, and writes directly back to the original file:

import os

def update_file(file_path, new_content, line_num):
    # Note: line_num uses 0-based indexing. If you're passing 1-based line numbers, add line_num -= 1 here
    try:
        # Read all lines from the file
        with open(file_path, 'r') as f:
            lines = f.readlines()
        
        # Make sure the line number is within bounds
        if line_num < 0 or line_num >= len(lines):
            raise IndexError("Line number is out of the file's line range")
        
        # Ensure the new content ends with a newline to maintain formatting
        if not new_content.endswith('\n'):
            new_content += '\n'
        lines[line_num] = new_content
        
        # Write the modified lines back to the file
        with open(file_path, 'w') as f:
            f.writelines(lines)
            
        print(f"Successfully updated line {line_num} in {file_path}")
    except Exception as e:
        print(f"Error updating file: {str(e)}")

Even safer version (uses temporary files) #

If you want to avoid risking data loss if the write operation fails mid-way, use a temporary file and atomically replace the original file. This ensures your original file stays intact unless the entire write succeeds:

import os
import tempfile

def safe_update_file(file_path, new_content, line_num):
    # line_num uses 0-based indexing
    try:
        with open(file_path, 'r') as f:
            lines = f.readlines()
        
        if line_num < 0 or line_num >= len(lines):
            raise IndexError("Line number is out of the file's line range")
        
        if not new_content.endswith('\n'):
            new_content += '\n'
        lines[line_num] = new_content
        
        # Create a temporary file in the same directory as the original
        with tempfile.NamedTemporaryFile(mode='w', delete=False, dir=os.path.dirname(file_path)) as temp_f:
            temp_f.writelines(lines)
        
        # Atomically replace the original file with the temporary one
        os.replace(temp_f.name, file_path)
        
        print(f"Successfully updated line {line_num} in {file_path}")
    except Exception as e:
        # Clean up the temporary file if something went wrong
        if 'temp_f' in locals() and os.path.exists(temp_f.name):
            os.remove(temp_f.name)
        print(f"Error updating file: {str(e)}")

How to use these functions #

For example, to update line 2 (0-based, so actually the third line if you count from 1) in example.txt with "New updated line content":

update_file("example.txt", "New updated line content", 2)

内容的提问来源于stack exchange，提问作者Phazoning