使用KeyListener移动矩形遇问题：矩形仅显示无法移动

Hey there! Let's figure out why your rectangle isn't moving even though your code looks similar to working versions. KeyListener can be tricky because it has strict focus requirements, and it's easy to miss a few critical steps. Here are the most common fixes to get your rectangle moving:

1. Make sure your JPanel can receive focus #

KeyListener only works on components that have focus. Your roomwars JPanel isn't set to accept focus by default, so add this in your constructor:

setFocusable(true);

After adding the panel to your JFrame, also make sure it grabs focus when the window opens:

panel.requestFocusInWindow();

2. Don't forget to register the KeyListener #

Just implementing the KeyListener interface isn't enough—you have to tell the component to listen for key events. Add this line in your JPanel's constructor:

addKeyListener(this);

3. Call repaint() after updating the rectangle's position #

When you change the x/y coordinates of your rectangle, Swing won't automatically redraw the component. You need to trigger a repaint manually in your key event handlers. For example:

@Override
public void keyPressed(KeyEvent e) {
    int key = e.getKeyCode();
    if (key == KeyEvent.VK_LEFT) {
        rectX -= 5; // Adjust your rectangle's x position
    }
    // Add other direction logic here...
    
    repaint(); // This tells Swing to redraw the panel with the new position
}

4. Always call super.paintComponent(g) in your paint method #

If you're overriding paintComponent, you must call the parent class's implementation first to clear old drawings and handle Swing's internal painting. Your paint method should look like this:

@Override
protected void paintComponent(Graphics g) {
    super.paintComponent(g); // Critical for clean redraws
    g.fillRect(rectX, rectY, rectWidth, rectHeight);
}

A quick fixed version of your code (example) #

Here's how your code might look with all these fixes applied:

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;

// Follow Java naming conventions: capitalize class names
public class RoomWars extends JPanel implements ActionListener, KeyListener {
    private int rectX = 50;
    private int rectY = 50;
    private final int RECT_SIZE = 50;

    public RoomWars() {
        setFocusable(true); // Allow focus
        addKeyListener(this); // Register the listener
    }

    @Override
    protected void paintComponent(Graphics g) {
        super.paintComponent(g);
        g.setColor(Color.RED);
        g.fillRect(rectX, rectY, RECT_SIZE, RECT_SIZE);
    }

    @Override
    public void keyPressed(KeyEvent e) {
        int speed = 5;
        switch(e.getKeyCode()) {
            case KeyEvent.VK_LEFT: rectX -= speed; break;
            case KeyEvent.VK_RIGHT: rectX += speed; break;
            case KeyEvent.VK_UP: rectY -= speed; break;
            case KeyEvent.VK_DOWN: rectY += speed; break;
        }
        repaint(); // Update the display
    }

    @Override
    public void keyReleased(KeyEvent e) {}
    @Override
    public void keyTyped(KeyEvent e) {}
    @Override
    public void actionPerformed(ActionEvent e) {}

    public static void main(String[] args) {
        JFrame frame = new JFrame("Room Wars");
        RoomWars panel = new RoomWars();
        frame.add(panel);
        frame.setSize(400, 400);
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        frame.setVisible(true);
        panel.requestFocusInWindow(); // Grab focus for key events
    }
}

Bonus tip: Consider using Key Bindings instead #

KeyListener is fragile because of its focus dependency. For Swing apps, it's often better to use Key Bindings—they let you map key events to actions regardless of whether the component has focus. But the fixes above should get your KeyListener implementation working first.

内容的提问来源于stack exchange，提问作者christiana ceesay