删除用户前是否需检查用户存在？代码实现方案咨询

Great question! Let's break this down clearly—your existing code has a potential issue, and adding an explicit check for the user's existence is absolutely the better approach. Here's why:

现有写法的问题 #

Your current code:

var user = await _userManager.FindByNameAsync(username);
var result = await _userManager.DeleteAsync(user);
return new JsonResult(result);

If the user doesn't exist, FindByNameAsync returns null. When you pass null to DeleteAsync in ASP.NET Core Identity, this will throw an ArgumentNullException (the method doesn't accept a null user parameter). This means your request will fail with an unhandled exception (usually a 500 internal server error) instead of returning a friendly, expected error response to the client.

为什么添加存在性判断更优 #

Adding an if check to handle the "user not found" scenario fixes this issue and brings several benefits:

• Avoids runtime exceptions: You catch the missing user case proactively instead of letting an exception bubble up.
• Clearer error feedback: You can return a specific business-friendly error message (like "User {username} does not exist") instead of a generic "argument cannot be null" error.
• More readable code: Other developers looking at your code will immediately understand that you're accounting for the scenario where the user might not exist.

优化后的代码示例 #

Here's how to adjust your code with the check:

var user = await _userManager.FindByNameAsync(username);
if (user == null)
{
    return new JsonResult(IdentityResult.Failed(new IdentityError 
    { 
        Description = $"User {username} does not exist and cannot be deleted." 
    }));
}

var result = await _userManager.DeleteAsync(user);
return new JsonResult(result);

特殊情况：全局异常处理 #

If your application already has a global exception handler that catches ArgumentNullException and converts it to a user-friendly response, your original code might not crash—but it's still less ideal. The explicit check gives you control over the error message and ensures you're handling the business logic explicitly, rather than relying on framework behavior that could change in future versions.

内容的提问来源于stack exchange，提问作者mbrc