Android开发疑问：实现关注按钮时onPrepareOptionsMenu为何提前执行？

Hey there! Let's tackle this issue you're facing with your follow/unfollow button in your Android app. I've been in this exact spot before, so I know how frustrating it can be when the menu doesn't update correctly.

First, the Reason It's Happening #

The onPrepareOptionsMenu() method is called by Android right before the options menu is displayed—this includes the first time the menu loads (right after onCreateOptionsMenu()) and every time the user opens the menu again (like tapping the three-dot icon).

The problem here is that your code to check if the user is following the profile is probably running asynchronously (like fetching data from an API or database), which takes time to complete. But onPrepareOptionsMenu() runs immediately when the menu is about to show, way before your async operation finishes. So when the method executes, you don't have the updated follow status yet, leading to incorrect button text.

How to Fix It #

The solution is simple: tell Android to re-prepare the menu once you have the follow status data. Here's how to do it step by step:

1. First, store the follow status in a variable in your UserProfileActivity (e.g., private boolean isFollowing = false;).

2. Fetch the follow status asynchronously (like you probably already are), and once you get the result, update the variable and trigger a menu refresh:

   private void loadFollowStatus(String targetUserId) {
       // Example: Using Retrofit to check follow status from an API
       yourApiClient.checkFollowStatus(targetUserId)
           .enqueue(new Callback<FollowResponse>() {
               @Override
               public void onResponse(Call<FollowResponse> call, Response<FollowResponse> response) {
                   if (response.isSuccessful() && response.body() != null) {
                       // Update the follow status variable
                       isFollowing = response.body().isUserFollowing();
                       // Tell Android to re-prepare the options menu
                       invalidateOptionsMenu();
                   }
               }
   
               @Override
               public void onFailure(Call<FollowResponse> call, Throwable t) {
                   // Handle error cases here (e.g., show a toast)
               }
           });
   }
   

3. Update your onPrepareOptionsMenu() to use the isFollowing variable to set the button text:

   @Override
   public boolean onPrepareOptionsMenu(Menu menu) {
       MenuItem followButton = menu.findItem(R.id.action_follow_unfollow);
       if (followButton != null) {
           // Set the button text based on the current follow status
           followButton.setTitle(isFollowing ? "unfollow" : "follow");
       }
       return super.onPrepareOptionsMenu(menu);
   }
   

4. Bonus: If using LiveData (for example, with ViewModel), you can observe the follow status and trigger the menu refresh automatically:

   // In your Activity's onCreate() or onStart()
   yourViewModel.getFollowStatus().observe(this, followStatus -> {
       isFollowing = followStatus;
       invalidateOptionsMenu();
   });
   

Key Takeaway #

onPrepareOptionsMenu() runs early, but you can force it to re-run whenever your data is ready using invalidateOptionsMenu(). This ensures the button always shows the correct text based on the latest follow status.

内容的提问来源于stack exchange，提问作者Nope