C#单行if语句含两个操作导致外层if判断结果异常

Hey there! Let's dig into what's tripping you up here. It sounds like you're running into two common pitfalls with single-line nested ifs in C# (especially in Unity): null reference exceptions and unexpected else binding—and they're making your logic behave nothing like you expect.

First, let's clarify the core issue you mentioned: you said draggedItem.GetComponent<PreparedItem>().CheckPreparationAvailability() returns false, but you're hitting an exception instead of getting that false result. Chances are, you're not actually reaching the CheckPreparationAvailability() call at all. Here's why:

The #1 Culprit: Missing Null Checks #

If draggedItem.GetComponent<PreparedItem>() returns null (meaning the component isn't attached to the object), trying to call CheckPreparationAvailability() on that null reference will throw a NullReferenceException immediately. Your code never gets to evaluate whether the method returns false—it crashes before that point.

The Second Trap: Indentation vs. Actual Code Scope #

Single-line ifs are tricky because indentation doesn't define scope in C#. If you wrote something like this:

if (outerCondition)
    if (draggedItem.GetComponent<PreparedItem>().CheckPreparationAvailability())
        ExecuteSuccessLogic();
else
    ExecuteFailureLogic();

You might think the else belongs to the outer if, but it actually binds to the closest inner if. That means even if your outer condition fails, the else won't run as you expect—this is a classic indentation trick that breaks logic.

Fixes to Get Your Logic Behaving as Expected #

Let's rewrite this to avoid both issues:

1. Explicit Null Checks + Clear Scope (Most Readable) #

Break down the checks step by step, and use curly braces to define exactly which code belongs to each if/else block:

// First, make sure draggedItem itself isn't null
if (draggedItem != null)
{
    PreparedItem preparedItem = draggedItem.GetComponent<PreparedItem>();
    // Now check if the component exists, then call your method
    if (preparedItem != null && preparedItem.CheckPreparationAvailability())
    {
        // Your success logic here
    }
    else
    {
        // Runs if either the component is missing OR CheckPreparationAvailability returns false
        // This is where you expected to land with a false result
    }
}
else
{
    // Handle case where draggedItem is null
}

2. Compact Single-Line Check (Using Short-Circuit Logic) #

If you prefer a more concise single-line approach, use TryGetComponent (safer than GetComponent because it avoids null references) and short-circuit && operators—these ensure later checks only run if earlier ones pass:

if (draggedItem != null && 
    draggedItem.TryGetComponent(out PreparedItem preparedItem) && 
    preparedItem.CheckPreparationAvailability())
{
    // Success logic
}
else
{
    // Runs if any check fails: draggedItem is null, component missing, or method returns false
}

Key Takeaways #

• Never skip null checks: In Unity, GetComponent often returns null if the component isn't attached—always validate before calling methods on the result.
• Curly braces are your friend: Even for single-line ifs, using {} removes ambiguity about which code belongs to which block, especially with nested logic.
• Short-circuit operators save you: && stops evaluating conditions as soon as one fails, preventing unnecessary (and dangerous) method calls on null objects.

内容的提问来源于stack exchange，提问作者Eray Tuncer