ASP.NET MVC C#字典键添加列表失败及方法返回结果异常求助

Hey there! Let's break down and fix the two problems you're running into in your project. I'll walk through each issue with clear explanations and code examples to get you sorted.

1. Unable to Add a List to a Specific Key in a Dictionary #

This usually happens when you try to modify a list for a key that doesn't exist in the dictionary yet—C# will throw a KeyNotFoundException in that case. Here's how to fix it:

Common Mistake Example #

If you're doing something like this, it'll fail when the key isn't present:

// Initialize the dictionary
Dictionary<int, List<Doctor>> specialityDoctorMap = new Dictionary<int, List<Doctor>>();

// Trying to add to a non-existent key throws an error
specialityDoctorMap[3].Add(new Doctor { Id = 42, Name = "Dr. Emily Carter" });

Fixes #

You have a few clean ways to handle this:

Option 1: Check for the Key First

Explicitly verify if the key exists before adding the list or elements:

int targetSpecialityId = 3;

if (!specialityDoctorMap.ContainsKey(targetSpecialityId))
{
    // Create a new list for the key if it doesn't exist
    specialityDoctorMap[targetSpecialityId] = new List<Doctor>();
}
// Now safely add the doctor to the list
specialityDoctorMap[targetSpecialityId].Add(new Doctor { Id = 42, Name = "Dr. Emily Carter" });

Option 2: Use TryGetValue (More Efficient)

This method avoids checking the dictionary twice (once for existence, once for retrieval):

int targetSpecialityId = 3;

if (!specialityDoctorMap.TryGetValue(targetSpecialityId, out var doctorList))
{
    // Initialize a new list and add it to the dictionary
    doctorList = new List<Doctor>();
    specialityDoctorMap[targetSpecialityId] = doctorList;
}
doctorList.Add(new Doctor { Id = 42, Name = "Dr. Emily Carter" });

Option 3: Concise C# 7+ Syntax

A shorter way using logical OR to handle initialization:

int targetSpecialityId = 3;

// If the key doesn't exist, create a new list and assign it
specialityDoctorMap.TryGetValue(targetSpecialityId, out var list) 
    || (list = specialityDoctorMap[targetSpecialityId] = new List<Doctor>());

list.Add(new Doctor { Id = 42, Name = "Dr. Emily Carter" });

2. GetDoctorSpecialityList Returns All Doctors for Every Specialty #

The core issue here is that your method isn't filtering doctors by their associated specialty ID. Let's assume your GetSpecialityList works correctly (returns a map of Specialty ID → Specialty Name). Here's how to fix the doctor mapping:

Common Mistake Example #

If your current code looks like this, it's assigning all doctors to every specialty:

public Dictionary<int, List<Doctor>> GetDoctorSpecialityList()
{
    var specialityMap = GetSpecialityList();
    var allDoctors = db.Doctors.ToList(); // Grabs every doctor in the DB
    var result = new Dictionary<int, List<Doctor>>();

    foreach (var speciality in specialityMap)
    {
        // ❌ No filtering—all doctors go to every specialty
        result[speciality.Key] = allDoctors;
    }

    return result;
}

Correct Implementation #

We need to filter doctors by their SpecialityId (assuming your Doctor model has this foreign key field). Here are two approaches:

Option 1: Filter Per Specialty (Simple)

Loop through each specialty and fetch only the doctors linked to it:

public Dictionary<int, List<Doctor>> GetDoctorSpecialityList()
{
    var specialityMap = GetSpecialityList();
    var result = new Dictionary<int, List<Doctor>>();

    foreach (var speciality in specialityMap)
    {
        // ✅ Filter doctors by the current specialty ID
        var doctorsInSpecialty = db.Doctors
            .Where(doctor => doctor.SpecialityId == speciality.Key)
            .ToList();
        
        // Assign the filtered list to the specialty key
        result[speciality.Key] = doctorsInSpecialty;
    }

    return result;
}

Option 2: Group Doctors First (More Efficient)

To avoid multiple database calls (one per specialty), group doctors by their SpecialityId first, then map to your specialty list:

public Dictionary<int, List<Doctor>> GetDoctorSpecialityList()
{
    var specialityMap = GetSpecialityList();
    // Group all doctors by their SpecialtyId once
    var groupedDoctors = db.Doctors
        .GroupBy(doctor => doctor.SpecialityId)
        .ToDictionary(group => group.Key, group => group.ToList());

    var result = new Dictionary<int, List<Doctor>>();

    foreach (var speciality in specialityMap)
    {
        // If the specialty has no doctors, return an empty list instead of null
        result[speciality.Key] = groupedDoctors.TryGetValue(speciality.Key, out var doctors) 
            ? doctors 
            : new List<Doctor>();
    }

    return result;
}

Additional Checks #

If this still doesn't work, double-check these:

• Ensure your Doctor model has a valid SpecialityId foreign key field that links to the Speciality table.
• Verify that your database has correct SpecialityId values for each doctor (no orphaned records where SpecialityId is null or invalid).
• Confirm that your LINQ filter uses the correct field name (e.g., not DoctorId instead of SpecialityId).

内容的提问来源于stack exchange，提问作者user7292151