iOS/Swift：UITabBarController传值代码运行正常但存在实例创建问题

Hey there! Let's break down the issues in your current code and get it more robust—right now those forced unwraps and downcasts are ticking time bombs that could crash your app unexpectedly.

The Problem Spots in Your Original Code #

Here's your code for reference, with the risky bits highlighted:

override func prepare(for segue: UIStoryboardSegue, sender: Any?) { 
    let barViewControllers = segue.destination as! UITabBarController // ❌ Forced downcast: crashes if destination isn't UITabBarController
    let nav = barViewControllers.viewControllers![0] as! UINavigationController // ❌ Forced array access + downcast: crashes if viewControllers is empty or first item isn't UINavigationController
    let mainVC = nav.viewControllers[0] as! MainForecastViewController // ❌ Forced array access + downcast: crashes if nav's viewControllers is empty or root isn't MainForecastViewController
    if let lat = Double(latitudeTextField.text!) { // ❌ Forced text unwrap: crashes if text is nil
        mainVC.latPassed = lat 
    } 
    if let lng = Double(longitudeTextField.text!) { // ❌ Same forced unwrap issue here
        mainVC.LongPassed = lng 
    } 
}

Robust, Crash-Safe Version #

Here's how to rewrite it with safety checks and better Swift practices:

override func prepare(for segue: UIStoryboardSegue, sender: Any?) {
    // 1. Safely downcast the segue destination to UITabBarController
    guard let tabBarController = segue.destination as? UITabBarController else {
        print("Error: Segue destination is not a UITabBarController")
        return
    }
    
    // 2. Safely get the first tab's navigation controller (using optional chain + downcast)
    guard let navController = tabBarController.viewControllers?.first as? UINavigationController else {
        print("Error: First tab is missing or not a UINavigationController")
        return
    }
    
    // 3. Safely access the navigation stack's root view controller
    guard let mainForecastVC = navController.viewControllers.first as? MainForecastViewController else {
        print("Error: Navigation root is not MainForecastViewController")
        return
    }
    
    // 4. Handle latitude input without forced unwraps
    if let latText = latitudeTextField.text, let latitude = Double(latText) {
        mainForecastVC.latPassed = latitude
    } else {
        print("Warning: Invalid or missing latitude input")
        // Optional: Add logic to set a default value or alert the user here
    }
    
    // 5. Handle longitude input (plus fix Swift naming convention: lowercase first letter)
    if let lngText = longitudeTextField.text, let longitude = Double(lngText) {
        mainForecastVC.longPassed = longitude // Renamed from LongPassed to match Swift camelCase
    } else {
        print("Warning: Invalid or missing longitude input")
        // Optional: Add default value or user alert logic here
    }
}

Key Improvements #

• guard let for safety: We use guard to validate each step—if any cast or optional access fails, we log an error and exit early instead of crashing.
• Optional chains: viewControllers?.first safely accesses the first element of the array only if the array exists (isn't nil).
• No forced unwraps: We never use ! on optional values like textField.text, which could be nil (e.g., if the text field is empty in some edge cases).
• Swift naming compliance: Changed LongPassed to longPassed—Swift conventions require lowercase first letters for properties.

内容的提问来源于stack exchange，提问作者RochNoure