使用SqlDataReader值的If语句失效及电商购物车数量调整逻辑咨询

Hey there! Let's tackle both your cart quantity adjustment logic and the pesky SqlDataReader problem one by one.

1. Implementing the "-" Button Logic for Cart Items #

Based on your requirements, here's a clear, step-by-step approach to build the quantity decrease functionality:

Core Logic Breakdown #

• First, fetch the selected item's CategoryID, current Quantity, and HoursWork value from your data source (database or session).
• Check if the CategoryID is either 3 or 4.
• If it is, verify that the item's quantity is greater than 1 (to prevent negative quantities).
• If both conditions are met:
  • Decrease the item's quantity by 1.
  • Reduce the HoursWork value accordingly (adjust the calculation if your business rule uses a different hour-per-item ratio).

Example Code (C# ASP.NET Context) #

// Assume we're handling a button click event
protected void DecreaseQuantity_Click(object sender, EventArgs e)
{
    // Get the selected item's ID from the button's CommandArgument
    int itemId = int.Parse(((LinkButton)sender).CommandArgument);
    
    string connString = ConfigurationManager.ConnectionStrings["YourConnString"].ConnectionString;
    using (SqlConnection conn = new SqlConnection(connString))
    {
        string query = "SELECT CategoryID, Quantity, HoursWork FROM CartItems WHERE ItemID = @ItemID";
        using (SqlCommand cmd = new SqlCommand(query, conn))
        {
            cmd.Parameters.AddWithValue("@ItemID", itemId);
            conn.Open();
            using (SqlDataReader reader = cmd.ExecuteReader())
            {
                if (reader.Read()) // Critical: Move reader to the first record
                {
                    int categoryId = reader.GetInt32(reader.GetOrdinal("CategoryID"));
                    int currentQty = reader.GetInt32(reader.GetOrdinal("Quantity"));
                    decimal currentHours = reader.GetDecimal(reader.GetOrdinal("HoursWork"));

                    // Apply your category-specific logic
                    if (categoryId == 3 || categoryId == 4)
                    {
                        if (currentQty > 1)
                        {
                            // Update quantity and HoursWork in database
                            string updateQuery = "UPDATE CartItems SET Quantity = @NewQty, HoursWork = @NewHours WHERE ItemID = @ItemID";
                            using (SqlCommand updateCmd = new SqlCommand(updateQuery, conn))
                            {
                                updateCmd.Parameters.AddWithValue("@NewQty", currentQty - 1);
                                // Subtract 1 hour per item (adjust if needed)
                                updateCmd.Parameters.AddWithValue("@NewHours", currentHours - 1);
                                updateCmd.Parameters.AddWithValue("@ItemID", itemId);
                                
                                reader.Close(); // Close reader before executing update
                                updateCmd.ExecuteNonQuery();
                            }
                        }
                    }
                    else
                    {
                        // Handle non-3/4 categories: only adjust quantity
                        if (currentQty > 1)
                        {
                            string updateQtyQuery = "UPDATE CartItems SET Quantity = @NewQty WHERE ItemID = @ItemID";
                            using (SqlCommand updateQtyCmd = new SqlCommand(updateQtyQuery, conn))
                            {
                                updateQtyCmd.Parameters.AddWithValue("@NewQty", currentQty - 1);
                                updateQtyCmd.Parameters.AddWithValue("@ItemID", itemId);
                                
                                reader.Close();
                                updateQtyCmd.ExecuteNonQuery();
                            }
                        }
                    }
                }
            }
        }
    }
    // Refresh the cart to show updated values
    Response.Redirect(Request.RawUrl);
}

2. Fixing the SqlDataReader If Statement Issue #

If your If statements using SqlDataReader values aren't working, here are the most common fixes to check:

Common Causes & Solutions #

• Forgot to call reader.Read(): You must call this method to move the reader to the first record. Without it, the reader stays positioned before any data, so no values are accessible.

  // Wrong: No Read() call
  if (reader["CategoryID"] == 3) { ... }
  
  // Correct:
  if (reader.Read())
  {
      int categoryId = (int)reader["CategoryID"];
      if (categoryId == 3) { ... }
  }
  

• Data type mismatch: Directly comparing reader["CategoryID"] == 3 can fail because reader["CategoryID"] returns an object. Always cast it to the correct data type first (int, string, etc.).
• Incorrect field name: Double-check that the column name in your SQL query matches what you're using in the reader. For example, if your database column is Category_Id but you use reader["CategoryID"], this will return null or throw an error.
• Reader closed prematurely: Never close the reader or connection before accessing values. Use using statements (like in the example above) to handle disposal automatically.
• Null values: If CategoryID could be null, add a check for DBNull.Value before casting:

  if (!reader.IsDBNull(reader.GetOrdinal("CategoryID")))
  {
      int categoryId = reader.GetInt32(reader.GetOrdinal("CategoryID"));
      // Your logic here
  }
  

内容的提问来源于stack exchange，提问作者Rebecca Hand