Task Listener是否需调用finish()？相关实践疑问求解

Great question—let’s unpack this clearly, since it’s all about matching the code to your specific use case.

First, calling finish() in OnSuccessListener() or OnFailureListener() is a common practice, but not a required one. It’s typically used in scenarios where the sole purpose of the Activity is to run that Task: think of a "Upload Photo" Activity that closes automatically once the upload succeeds/fails, sending the user back to the previous screen without extra steps. It’s a UX choice to keep things streamlined when the Activity’s job is done.

You’re right that your app will run perfectly fine without calling finish()—this method only destroys the current Activity instance, which is independent of the Task’s execution. The Task will still complete its work whether the Activity is alive or not (though you do need to watch for memory leaks if the Task holds a reference to the Activity after it’s destroyed, but that’s a separate concern).

For your specific scenario: if your SubActivity needs to stay active after the Task finishes (to show results, let the user take more actions, etc.), you absolutely should not call finish() in the listeners. Instead, use the Task’s result to update your SubActivity’s UI, show a success/failure message, or trigger other in-Activity logic. Here’s a quick example of how that might look:

// In your SubActivity
myTask.addOnSuccessListener(taskResult -> {
    // Update UI with the result instead of closing
    resultTextView.setText("Task succeeded! Result: " + taskResult);
    // Maybe enable a button for further actions
    continueButton.setEnabled(true);
}).addOnFailureListener(error -> {
    // Show an error message to the user
    Toast.makeText(this, "Task failed: " + error.getLocalizedMessage(), Toast.LENGTH_LONG).show();
    // Keep the Activity open so the user can retry or adjust inputs
});

A quick note to keep in mind: if your Task runs asynchronously, make sure you handle cases where the user navigates away from the SubActivity before the Task finishes. You might want to cancel the Task in onDestroy() to avoid unnecessary work or memory leaks, using something like myTask.cancel(true).

At the end of the day, whether to call finish() comes down to your app’s user flow and what the Activity is supposed to do. There’s no "one size fits all" rule—only what makes sense for your users.

内容的提问来源于stack exchange，提问作者Inwu