这段JNI代码是否存在内存泄漏？std::string转jByteArray返回是否正确？

Let's break down your questions one by one in a straightforward way:

Is the code correct? #

For most use cases, yes—it will successfully convert your std::string to a jByteArray and pass it back to Java. But there are a few small improvements and notes to consider:

• Casting best practice: Your code uses a C-style cast (jbyte*)str.c_str() to convert the const char* from c_str() to jbyte*. Since SetByteArrayRegion only reads from the input buffer (it doesn’t modify it), this is safe, but using reinterpret_cast<const jbyte*>(str.c_str()) is more explicit and avoids discarding the const qualifier unnecessarily (a cleaner, safer approach).
• Signed vs unsigned bytes: jbyte maps to signed char, while std::string stores bytes as unsigned char. If your string contains bytes with values greater than 127, they’ll show up as negative values in Java’s byte type. This is usually not an issue for raw binary data or UTF-8 (you can treat them as unsigned in Java with & 0xFF), but it’s good to keep in mind.
• Error checking gap: If NewByteArray fails (e.g., due to out-of-memory), it returns NULL. Calling SetByteArrayRegion on a NULL array will trigger an unhandled exception. Adding a quick check for NULL makes the code more robust.

Do you need to release resources? #

No, you don’t need to explicitly release any resources here:

• The jByteArray created with NewByteArray is returned to Java. The JVM takes ownership of this object and will garbage collect it when it’s no longer referenced.
• The std::string str is a local stack variable—it will be automatically destroyed when the function exits, freeing its internal buffer.

Is there a memory leak? #

Nope, there are no memory leaks in this code. All allocated memory is properly managed:

• The std::string’s internal buffer is handled by the string itself and cleaned up when it goes out of scope.
• The jByteArray is handed off to the JVM, which takes care of its lifecycle.

Improved Version with Error Checking #

Here’s a refined version of your code that addresses the error checking and casting points:

JNIEXPORT jbyteArray JNICALL Java_my_project_byteArray0 (JNIEnv * env, jobject jo) { 
    std::string str = get_something().string(); 
    jbyteArray ba = env->NewByteArray(str.size()); 
    if (ba == nullptr) {
        // NewByteArray already throws an OutOfMemoryError; just return NULL
        return nullptr;
    }
    // Explicit, safe cast to const jbyte*
    env->SetByteArrayRegion(ba, 0, str.size(), reinterpret_cast<const jbyte*>(str.c_str())); 
    return ba; 
}

内容的提问来源于stack exchange，提问作者dgabriel