如何编写JavaScript函数：查找指定字符首次出现位置

Let's break down what's going wrong with your current code first. Your loop checks str.indexOf(x) === i on every iteration, and immediately logs "character not found" whenever that condition fails. That means for every character before your target (like 'a', 'b', 'c', 'd' when searching for 'e' in "abcdefg"), you're spamming the error message—way too early! We only want to log that message if we finish checking the entire string and never find the character.

Why Your Original Code Fails #

• The indexOf() method already gives you the first occurrence index of the character, so using it inside a loop like this is redundant and causes those premature error logs.
• Your else clause runs on every single iteration where the current index doesn't match the target index, which isn't the behavior you want.

Solution 1: Use indexOf() Directly (Clean & Efficient) #

Since JavaScript's built-in indexOf() method does exactly what you need—returns the first index of a character, or -1 if it doesn't exist—we can simplify the function a lot:

function findFirstCharPosition(str, char) {
  const position = str.indexOf(char);
  if (position !== -1) {
    console.log(position);
  } else {
    console.log("character not found");
  }
}

// Test it out
findFirstCharPosition("abcdefg", "e"); // Outputs: 4
findFirstCharPosition("hello world", "z"); // Outputs: character not found

Solution 2: Manual Loop (If You Want to Implement Traversal Yourself) #

If you want to practice writing the loop logic manually instead of relying on indexOf(), here's how to do it correctly:

function findFirstCharPosition(str, char) {
  let foundIndex = -1;
  
  // Loop through each character in the string
  for (let i = 0; i < str.length; i++) {
    if (str[i] === char) {
      foundIndex = i;
      break; // Exit the loop immediately once we find the first match
    }
  }

  // Decide output after checking all characters
  if (foundIndex !== -1) {
    console.log(foundIndex);
  } else {
    console.log("character not found");
  }
}

// Test cases
findFirstCharPosition("abcdefg", "e"); // Outputs: 4
findFirstCharPosition("test string", "x"); // Outputs: character not found

Key Fixes from Your Original Code #

• We compare str[i] directly to the target character instead of using indexOf() inside the loop (no more redundant checks).
• The error message is moved outside the loop, so it only runs if we finish the entire traversal without finding the character.
• We use let i instead of an undeclared i to avoid creating a global variable (a common bad practice in JavaScript).

内容的提问来源于stack exchange，提问作者bk_kk