Node.js+Express+MySQL异步查询致Session ID生成循环阻塞求助

Hey there! Let's break down why your code is stuck and how to fix it.

The Root Problem #

Your while loop runs synchronously, but database queries with callbacks are asynchronous. That means the loop keeps generating new session IDs over and over before the DB query callback can update id_is_valid. To make it worse, you have a typo: is_is_valid = true instead of id_is_valid = true—so even if the callback ran in time, the variable wouldn't get updated correctly.

The Solution: Use Async/Await #

Async/await lets you write asynchronous code that reads like synchronous code, which is perfect for this scenario. Here's how to adjust your code:

First, make sure your database library supports promises (most modern ones like mysql2 do). If you're using the standard mysql package, you can wrap the query function in a promise, or switch to mysql2/promise for easier promise support.

Step 1: Rewrite with Async/Await (Promise-Based DB)

var express = require('express');
var router = express.Router();
// Use mysql2/promise instead of mysql for built-in promise support
var myDB = require('../db-connection'); // Assuming this exports a promise-based connection

function generateSession() {
  var session_id = '';
  var possible = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
  for (var i = 0; i < 30; i++) {
    session_id += possible.charAt(Math.floor(Math.random() * possible.length));
  }
  return session_id;
}

router.get('/generateSession', async function(req, res) {
  let session_id;
  let idExists;

  // Loop until we find an unused session ID
  do {
    session_id = generateSession();
    // Wait for the DB query to finish before proceeding
    const [results] = await myDB.query("SELECT * FROM activeUser WHERE session_id = ?", [session_id]);
    idExists = results.length > 0;
  } while (idExists);

  // Insert the valid session ID
  try {
    await myDB.query("INSERT INTO activeUser (is_registered, session_id) VALUES (0, ?)", [session_id]);
    res.status(200).json({ session_id: session_id });
  } catch (error) {
    console.error("Error inserting session:", error);
    res.status(500).send("Failed to create a valid session");
  }
});

module.exports = router;

Step 2: If You Can't Switch to Promise-Based DB (Wrap Callbacks in Promises)

If you need to keep using callback-based queries, wrap them in promises so you can use await:

// Helper functions to promisify DB queries
function checkSessionExists(sessionId) {
  return new Promise((resolve, reject) => {
    myDB.query("SELECT * FROM activeUser WHERE session_id = ?", [sessionId], (error, results) => {
      if (error) reject(error);
      else resolve(results.length > 0);
    });
  });
}

function insertSession(sessionId) {
  return new Promise((resolve, reject) => {
    myDB.query("INSERT INTO activeUser (is_registered, session_id) VALUES (0, ?)", [sessionId], (error) => {
      if (error) reject(error);
      else resolve();
    });
  });
}

// Updated route handler
router.get('/generateSession', async function(req, res) {
  let session_id;
  let idExists;

  do {
    session_id = generateSession();
    idExists = await checkSessionExists(session_id);
  } while (idExists);

  try {
    await insertSession(session_id);
    res.json({ session_id });
  } catch (err) {
    console.error(err);
    res.status(500).send("Failed to create session");
  }
});

Why This Works #

• The async keyword marks the route handler as asynchronous, allowing us to use await.
• await pauses the function execution until the DB query promise resolves, so we don't loop infinitely before checking the result.
• The do-while loop ensures we generate a new ID and check it each time until we find one that doesn't exist.
• Proper error handling with try/catch prevents server crashes and sends meaningful errors to the client.

Bonus Note #

Your 30-character random string has an extremely low chance of collision, so this loop will almost always exit on the first try. But it's still good practice to verify uniqueness!

内容的提问来源于stack exchange，提问作者Chris Ragsdale