C# WPF登录系统MySQL Reader报错：SQL语法错误求助

Hey there, let's figure out why your var DataReader = TeacherLoginsCommand.ExecuteReader(); line is throwing errors in your WPF login system. I've dealt with similar headaches before, so here are the most common fixes and checks to run through:

1. Ensure Your Database Connection Is Open & Properly Managed #

One of the most frequent culprits is a closed or improperly handled database connection. Many tutorials gloss over this, but you must open the connection before executing any commands, and use using statements to auto-manage resources (prevents leaks and unexpected closures).

Here's a corrected snippet:

// Replace with your actual connection string
string connectionString = "YourDatabaseConnectionStringHere";

using (SqlConnection connection = new SqlConnection(connectionString))
{
    connection.Open(); // Critical: Open the connection first!
    
    // Initialize your command with the open connection
    SqlCommand TeacherLoginsCommand = new SqlCommand(yourSqlQuery, connection);
    
    // Now execute the reader
    var DataReader = TeacherLoginsCommand.ExecuteReader();
    
    // Your login validation logic here...
}

2. Fix SQL Command Issues (Avoid Injection & Ensure Correct Parameters) #

If you're using user input for the login (which you are!), never concatenate strings into your SQL query—this causes SQL injection risks and frequent syntax/parameter errors. Instead, use parameterized queries, and double-check that your parameters match the database schema.

Bad (Error-Prone & Unsafe): #

// Never do this!
string query = $"SELECT * FROM Teachers WHERE Username='{txtUsername.Text}' AND Password='{txtPassword.Text}'";

Good (Safe & Reliable): #

string query = "SELECT * FROM Teachers WHERE Username = @Username AND Password = @Password";

SqlCommand TeacherLoginsCommand = new SqlCommand(query, connection);
// Add parameters matching your database column types
TeacherLoginsCommand.Parameters.AddWithValue("@Username", txtUsername.Text.Trim());
// For WPF PasswordBox, use the Password property (not Text)
TeacherLoginsCommand.Parameters.AddWithValue("@Password", txtPassword.Password);

3. Verify Database Permissions & Connection String #

• Check connection string accuracy: Make sure your server name, database name, authentication method (Windows/SQL Server), and credentials are correct. For local databases, common server names are (localdb)\MSSQLLocalDB or localhost\SQLEXPRESS—don't mix these up.
• Confirm user permissions: If using Windows auth, ensure the account running Visual Studio has read access to the Teachers table. If using SQL Server auth, verify the login has the necessary SELECT permissions on the table.
• Check if the database server is running: For local instances, open SQL Server Management Studio to confirm the server is active.

4. Capture Exact Error Details with Try-Catch #

Right now, you only know the error hits the ExecuteReader() line—but the actual root cause could be anything from a connection failure to a SQL syntax error. Wrap your code in a try-catch block to get the full error message:

private void Login_Button_Click(object sender, RoutedEventArgs e)
{
    try
    {
        // Your full login logic here (using the fixes above)
        string connectionString = "YourConnectionString";
        using (SqlConnection connection = new SqlConnection(connectionString))
        {
            connection.Open();
            string query = "SELECT * FROM Teachers WHERE Username = @Username AND Password = @Password";
            SqlCommand TeacherLoginsCommand = new SqlCommand(query, connection);
            TeacherLoginsCommand.Parameters.AddWithValue("@Username", txtUsername.Text.Trim());
            TeacherLoginsCommand.Parameters.AddWithValue("@Password", txtPassword.Password);
            
            var DataReader = TeacherLoginsCommand.ExecuteReader();
            
            if (DataReader.HasRows)
            {
                MessageBox.Show("Login successful!");
                // Navigate to main window or other logic
            }
            else
            {
                MessageBox.Show("Invalid username or password.");
            }
        }
    }
    catch (Exception ex)
    {
        // Show detailed error to pinpoint the issue
        MessageBox.Show($"Error occurred: {ex.Message}\n\nDetailed info: {ex.InnerException?.Message}");
    }
}

The error message from this catch block will tell you exactly what's wrong—whether it's a missing table, invalid credentials, or a closed connection.

Give these steps a try, starting with capturing the exact error. If you get a specific exception message, feel free to share it for more targeted help!

内容的提问来源于stack exchange，提问作者Omar Amer