如何优化首条件固定的VBA多AND条件If判断语句？

Great question! Your original code works, but repeating the same ComboBox3.ListIndex = 0 check in every condition is unnecessary—we can clean this up to make the code more readable and maintainable. Here are a couple of solid approaches tailored to your scenario:

1. Nested If + Select Case (Clean & Simple for Current Logic) #

Since the first condition is shared across all cases, we can check it once at the top, then use Select Case to handle the varying second condition. This cuts down on duplicate checks and makes the flow much clearer:

If ComboBox3.ListIndex = 0 Then
    Select Case ComboBox4.ListIndex
        Case 3
            ID1 = "GS-T10-"
        Case 4
            ID1 = "PB-"
        Case 5
            ID1 = "PE-"
        ' Add more cases here easily if you need to expand later
    End Select
End If

Why this works: #

• We only validate ComboBox3.ListIndex = 0 once instead of three times
• The Select Case structure makes it trivial to scan and update mappings between ComboBox4 indexes and prefixes
• Code is more compact and simpler to debug if issues pop up

2. Dictionary Mapping (Best for Scalable/Extensible Logic) #

If you expect to add more ComboBox4 index-to-prefix pairs down the line, using a Scripting.Dictionary turns your conditional logic into a clean lookup. This is ideal for growing codebases:

First, enable the Microsoft Scripting Runtime reference (or use late binding if you want to avoid references):

' Early binding (requires enabling the Microsoft Scripting Runtime reference)
Dim prefixMap As New Scripting.Dictionary
' Late binding (no reference needed)
'Dim prefixMap As Object
'Set prefixMap = CreateObject("Scripting.Dictionary")

' Populate the dictionary with your index-to-prefix pairs
With prefixMap
    .Add 3, "GS-T10-"
    .Add 4, "PB-"
    .Add 5, "PE-"
End With

' Use the dictionary to get the prefix
If ComboBox3.ListIndex = 0 Then
    ' Check if the ComboBox4 index exists in our map to avoid errors
    If prefixMap.Exists(ComboBox4.ListIndex) Then
        ID1 = prefixMap(ComboBox4.ListIndex)
    End If
End If

Why this works: #

• Adding new pairs is as easy as adding another .Add line—no messy nested conditionals to adjust
• Lookups are fast, even with dozens of entries
• Separates your mapping data from your core logic, making maintenance far simpler

Either approach eliminates redundant checks and cleans up your code. The nested Select Case is perfect for your current small set of conditions, while the dictionary shines if you plan to expand this logic later.

内容的提问来源于stack exchange，提问作者Omar