使用Moq模拟IAmazonS3进行Xunit单元测试时，AmazonS3类方法（GetPreSignedURL、PutObjectAsync、ListObjectsV2Async）测试失败的问题排查

我来帮你梳理下这个测试失败的问题，核心原因主要有两个，咱们一步步拆解解决：

问题根源分析 #

1. 非虚方法无法Mock的初始错误
   你最开始遇到的Non-overridable members (here: AmazonS3Client.GetPreSignedURL) may not be used in setup错误，是因为Moq只能Mock接口或者类的虚方法/抽象方法，而AmazonS3Client是具体类，它的GetPreSignedURL方法不是虚方法，所以没法直接Mock这个具体类。你后来换成IAmazonS3接口是正确的方向，但还有第二个更关键的问题。

2. 服务类的依赖硬编码，导致Mock对象无法生效
   你的AmazonServiceService类里，CreateAmazonS3Client方法是直接new AmazonS3Client(...)创建客户端实例的，这种硬编码的依赖方式，会导致你在测试中创建的Mock<IAmazonS3>实例根本不会被服务类使用——服务类始终会自己创建真实的S3客户端，这就是测试调用方法时失败的核心原因。

解决方案：重构服务类+调整测试代码 #

第一步：重构AmazonServiceService，支持依赖注入 #

我们需要修改服务类的构造函数，让它接受IAmazonS3作为依赖，这样测试时就能传入Mock对象了。同时可以保留原来的CreateAmazonS3Client方法作为生产环境的备选方式：

public class AmazonServiceService : IAmazonService
{
    private IAmazonS3 _client = null;

    // 新增构造函数，支持依赖注入IAmazonS3（测试用）
    public AmazonServiceService(IAmazonS3 s3Client)
    {
        _client = s3Client;
    }

    // 保留无参构造函数，用于生产环境手动创建客户端
    public AmazonServiceService()
    {
    }

    public void CreateAmazonS3Client(ObjectStorageConfiguration config)
    {
        _client = new AmazonS3Client(config.AccessKeyId, config.Secret, new AmazonS3Config
        {
            ServiceURL = config.ServerUrl
        });
    }

    // 以下原有方法保持不变
    public string GetPreSignedUrl(string? fileName, string? bucketName)
    {
        var request = new GetPreSignedUrlRequest
        {
            BucketName = bucketName,
            Key = fileName,
            Expires = DateTime.Now.AddDays(1)
        };
        return _client.GetPreSignedURL(request);
    }

    public string CreateDirectoryInS3Bucket(string? bucketName, string? directoryPath)
    {
        try
        {
            PutObjectRequest request = new()
            {
                BucketName = bucketName,
                Key = directoryPath,
                ContentBody = ""
            };
            var directoryCreated = _client.PutObjectAsync(request).Result;
            return directoryPath ?? "";
        }
        catch (AmazonS3Exception ex)
        {
            if (ex.StatusCode == HttpStatusCode.NotFound)
                throw new FileNotFoundException();
            throw;
        }
        catch (Exception ex)
        {
            throw;
        }
    }

    public async Task<bool> FileExist(string? filename, string? bucket)
    {
        try
        {
            var request = new ListObjectsV2Request
            {
                BucketName = bucket,
                Prefix = filename,
            };
            var response = await _client.ListObjectsV2Async(request);
            return response.S3Objects.Any();
        }
        catch (Exception ex)
        {
            return false;
        }
    }
}

第二步：调整测试代码，注入Mock的IAmazonS3实例 #

现在我们可以在测试中创建Mock的IAmazonS3，然后通过构造函数传入服务类，这样服务类就会使用我们的Mock对象而不是真实客户端了。下面是修复后的GetPreSignedUrl测试示例：

[Fact]
public void GetPreSignedUrl_WhenCalled_ReturnsExpectedUrl()
{
    // Arrange
    var expectedUrl = "https://testserver.com/bucketName/fileName?AWSAccessKeyId=AccessKey&Expires=1731254511&Signature=XS%2B19Ihey4u8jfLAOeQcv3ojrUw%3D";
    
    // 创建Mock的IAmazonS3
    var mockS3Client = new Mock<IAmazonS3>();
    
    // 注意：不要用测试里new的Request对象做Setup，服务类内部会创建自己的实例，用It.IsAny匹配任意请求
    mockS3Client
        .Setup(client => client.GetPreSignedURL(It.IsAny<GetPreSignedUrlRequest>()))
        .Returns(expectedUrl);

    // 通过构造函数注入Mock的客户端
    var objService = new AmazonServiceService(mockS3Client.Object);

    // Act
    var result = objService.GetPreSignedUrl("fileName", "bucketName");

    // Assert
    Assert.Equal(expectedUrl, result);
    mockS3Client.Verify(client => client.GetPreSignedURL(It.IsAny<GetPreSignedUrlRequest>()), Times.Once);
}

额外：PutObjectAsync和ListObjectsV2Async的Mock示例 #

测试CreateDirectoryInS3Bucket方法

[Fact]
public void CreateDirectoryInS3Bucket_WhenCalled_ReturnsDirectoryPath()
{
    // Arrange
    var bucketName = "test-bucket";
    var directoryPath = "test-dir/";
    var mockS3Client = new Mock<IAmazonS3>();
    
    // Mock PutObjectAsync方法，返回成功响应
    mockS3Client
        .Setup(client => client.PutObjectAsync(It.IsAny<PutObjectRequest>(), default))
        .ReturnsAsync(new PutObjectResponse());

    var objService = new AmazonServiceService(mockS3Client.Object);

    // Act
    var result = objService.CreateDirectoryInS3Bucket(bucketName, directoryPath);

    // Assert
    Assert.Equal(directoryPath, result);
    mockS3Client.Verify(client => client.PutObjectAsync(
        It.Is<PutObjectRequest>(req => req.BucketName == bucketName && req.Key == directoryPath), 
        default), Times.Once);
}

测试FileExist方法

[Fact]
public async Task FileExist_WhenFileExists_ReturnsTrue()
{
    // Arrange
    var filename = "test-file.txt";
    var bucketName = "test-bucket";
    var mockS3Client = new Mock<IAmazonS3>();
    
    // 构造包含目标文件的响应
    var mockResponse = new ListObjectsV2Response
    {
        S3Objects = new List<S3Object> { new S3Object { Key = filename } }
    };
    
    mockS3Client
        .Setup(client => client.ListObjectsV2Async(It.IsAny<ListObjectsV2Request>(), default))
        .ReturnsAsync(mockResponse);

    var objService = new AmazonServiceService(mockS3Client.Object);

    // Act
    var result = await objService.FileExist(filename, bucketName);

    // Assert
    Assert.True(result);
    mockS3Client.Verify(client => client.ListObjectsV2Async(
        It.Is<ListObjectsV2Request>(req => req.BucketName == bucketName && req.Prefix == filename), 
        default), Times.Once);
}

关键注意点 #

• 避免在Setup时使用具体的Request对象：因为服务类内部会创建自己的Request实例，和你测试里new的不是同一个对象，所以要用It.IsAny<T>或者It.Is<T>(condition)来匹配请求。
• 始终通过依赖注入传递Mock对象：不要在测试中调用CreateAmazonS3Client方法，否则会覆盖掉Mock的客户端，导致测试使用真实的S3连接。

备注：内容来源于stack exchange，提问作者Rupesh