Python 3多模块中单例元类重复定义是否为不良实践？

Great question! Repeating the Singleton metaclass definition across multiple files is absolutely a bad practice—let’s break down why, and how to fix it cleanly:

Why It’s Problematic #

• Violates the DRY Principle: Writing identical metaclass code in every file that needs a singleton means you’re duplicating logic. If you ever need to update the singleton behavior (like adding thread safety, or modifying instance cleanup), you’ll have to hunt down every copy and make the same change—tedious and error-prone.
• Consistency Risks: It’s easy to accidentally tweak the metaclass in one file but forget another. For example, if you add a check for kwargs in one Singleton definition but not the other, your different singleton classes will behave inconsistently, leading to hard-to-debug bugs.
• Unnecessary Bloat: Each repeated Singleton class is a separate object in memory. While this isn’t a huge performance hit, it’s unnecessary clutter that adds no value.

The Clean Solution: Centralize the Metaclass #

The fix is simple: move the Singleton metaclass into a dedicated, reusable module, then import it wherever you need it.

Step 1: Create a singleton.py module #

class Singleton(type):
    _instances = {}
    def __call__(cls, *args, **kwargs):
        if cls not in cls._instances:
            cls._instances[cls] = super(Singleton, cls).__call__(*args, **kwargs)
        return cls._instances[cls]

Step 2: Import and use it in your other files #

In Apple.py:

from singleton import Singleton

class Apple(metaclass=Singleton):
    pass

print(Apple() == Apple())  # Still returns True

In any other file needing a singleton (e.g., Orange.py):

from singleton import Singleton

class Orange(metaclass=Singleton):
    pass

print(Orange() == Orange())  # Works as expected

Bonus: Optional Improvements #

If you want to make your singleton even more robust, you could add thread safety (using a lock) or allow resetting instances for testing—all in one place, and every class using the metaclass gets the update automatically.

Trust me, taking the 2 minutes to centralize this will save you a ton of headache down the line when your codebase grows!

内容的提问来源于stack exchange，提问作者Nyxynyx