Rails 5中has_many through关联更新时的数据覆盖问题

Ah, this is a super common gotcha when working with has_many :through associations in Rails! The issue here is that your update logic isn't properly preserving existing Food associations—instead, it's only adding new ones and discarding the old ones. Let's break down how to fix this, step by step.

The Root Cause #

By default, if you're manually handling MealFood records in your update action (instead of using Rails' built-in association helpers), you're probably not accounting for existing associations. Rails can automatically manage these associations for you if you use the right parameter handling.

Fix 1: Use food_ids for Simplified Association Updates #

The easiest way to handle this is to leverage Rails' native support for updating many-to-many associations via the food_ids parameter. Here's how to adjust your code:

1. Update Your Form to Pass All Selected Food IDs

Make sure your edit form includes checkboxes (or a multi-select) for all foods you want to keep associated with the meal—including existing ones. Use collection_check_boxes to generate these easily:

<%= form_with(model: @meal) do |form| %>
  <!-- Add your other Meal fields here (name, description, etc.) -->
  
  <div class="field">
    <%= form.label :food_ids, "Select Foods" %>
    <%= form.collection_check_boxes :food_ids, Food.all, :id, :name do |checkbox| %>
      <%= checkbox.check_box %>
      <%= checkbox.label %>
    <% end %>
  </div>

  <%= form.submit "Update Meal" %>
<% end %>

This will submit an array of food_ids that includes every food you want linked to the meal (old and new).

2. Allow food_ids in Strong Parameters

Update your meal_params method to permit the food_ids array—this tells Rails it's safe to use these values to update the association:

private

def meal_params
  params.require(:meal).permit(:name, :description, # Add your other Meal attributes here
                               food_ids: []) # Allow the array of food IDs
end

3. Simplify Your Update Action

Now your update action can be streamlined—Rails will automatically handle adding new associations and removing any that aren't in the submitted food_ids array:

def update
  if @meal.update(meal_params)
    redirect_to @meal, notice: "Meal was successfully updated."
  else
    @meal_foods = @meal.meal_foods.includes(:food) # Re-fetch for the edit form
    render :edit
  end
end

Fix 2: If You Need to Use Nested Attributes (For Custom MealFood Data) #

If your MealFood model has additional attributes (like quantity, notes, etc.), you'll need to use nested attributes instead. Here's how to adjust that setup:

1. Enable Nested Attributes in the Meal Model

Add accepts_nested_attributes_for with allow_destroy: true to let Rails handle deleting old associations:

class Meal < ApplicationRecord
  has_many :meal_foods
  has_many :foods, through: :meal_foods
  accepts_nested_attributes_for :meal_foods, allow_destroy: true
end

2. Update the Form to Include Existing MealFood Records

In your edit form, render fields for existing meal_foods and include hidden fields for their id and a _destroy checkbox if you want to let users remove specific entries:

<%= form_with(model: @meal) do |form| %>
  <!-- Meal fields here -->

  <%= form.fields_for :meal_foods do |mf_form| %>
    <%= mf_form.hidden_field :id %>
    <%= mf_form.label :food_id, "Food" %>
    <%= mf_form.collection_select :food_id, Food.all, :id, :name %>
    <!-- Add any custom MealFood fields here (quantity, etc.) -->
    <%= mf_form.check_box :_destroy %>
    <%= mf_form.label :_destroy, "Remove this food" %>
  <% end %>

  <!-- Add a button to dynamically add new MealFood fields if needed -->
  <%= form.submit "Update Meal" %>
<% end %>

3. Permit Nested Attributes in Strong Parameters

Update meal_params to allow nested meal_foods_attributes, including id, food_id, _destroy, and any custom fields:

private

def meal_params
  params.require(:meal).permit(:name, :description,
                               meal_foods_attributes: [:id, :food_id, :quantity, :_destroy])
end

Why This Works #

When you use food_ids or nested attributes with allow_destroy: true, Rails compares the submitted data to the existing associations. It will:

• Add new associations for any food_ids not already linked to the meal
• Remove associations for any food_ids (or meal_foods marked _destroy) that aren't in the submitted data
• Keep existing associations that are present in the submission

内容的提问来源于stack exchange，提问作者Alexander Bogdanov