C++中if/else if/else逻辑无法准确输出结果问题排查

Hey there, let's sort out the issues with your array min/max code. From what you've shared, two big problems are causing incorrect (or missing) results: your code cuts off before reading the user's choice, and there's no actual logic to handle that choice and trigger the right calculation. Let's fix this step by step.

Key Issues in the Original Code #

• Incomplete input handling: The code stops right before reading the user's selection for min (0) or max (9)—the line cin >> MaxOrMin; is missing entirely.
• Missing branch logic: There's no if/else if/else block to check the user's input and call the corresponding FindMinimum or FindMaximum functions.
• Unused variables: FindMin and FindMax are declared but never assigned or used in the flow.

Fixed Full Code #

#include <iostream>
using namespace std;

// Prototype functions
void DisplayResult(float result);
float FindMinimum(float Array[5]);
float FindMaximum(float Array[5]);

// Global Variables (note: using global variables can make code harder to debug; consider passing arrays as parameters instead)
float Array[5];

// Main Function
int main() {
    cout << "Please enter 5 numbers: " << endl;
    for (int i = 0; i < 5; i++) {
        cin >> Array[i]; // Input for array
    }

    int userChoice; // Use int instead of float for cleaner equality checks
    cout << "Please enter '0' for minimum or '9' for maximum:" << endl;
    cin >> userChoice; // Now we actually capture the user's selection

    // Core logic to handle user input
    if (userChoice == 0) {
        float minVal = FindMinimum(Array);
        DisplayResult(minVal);
    } else if (userChoice == 9) {
        float maxVal = FindMaximum(Array);
        DisplayResult(maxVal);
    } else {
        cout << "Invalid input! Please enter 0 or 9 next time." << endl;
        return 1; // Exit with error code for invalid input
    }

    return 0;
}

// Implement DisplayResult function
void DisplayResult(float result) {
    cout << "The result is: " << result << endl;
}

// Implement FindMinimum function
float FindMinimum(float Array[5]) {
    float minVal = Array[0];
    for (int i = 1; i < 5; i++) {
        if (Array[i] < minVal) {
            minVal = Array[i];
        }
    }
    return minVal;
}

// Implement FindMaximum function
float FindMaximum(float Array[5]) {
    float maxVal = Array[0];
    for (int i = 1; i < 5; i++) {
        if (Array[i] > maxVal) {
            maxVal = Array[i];
        }
    }
    return maxVal;
}

What We Fixed #

1. Added input reading: We added cin >> userChoice; to capture the user's selection, and switched to an int type for more reliable equality checks (floating-point values can have precision issues for exact matches).
2. Added branch logic: The if/else if/else block now correctly routes the user's choice:
   • If input is 0, calculate and display the minimum value
   • If input is 9, calculate and display the maximum value
   • If input is anything else, show an error message and exit gracefully
3. Implemented helper functions: The original code only had function prototypes—we added the actual logic for FindMinimum, FindMaximum, and DisplayResult to make the program work end-to-end.
4. Cleaned up unused variables: Removed the unused MaxOrMin, FindMin, and FindMax variables, replacing them with local variables in main for better code practice.

Quick Note on Global Variables #

While your original code used global variables, it's generally better to move the array into main and pass it as a parameter to your functions. This avoids potential bugs from unintended global variable modifications and makes the code more modular.

内容的提问来源于stack exchange，提问作者Rob