命令行参数合法性校验需求：非正整数判断及整数输入校验

Hey there, let's work through fixing your command-line integer validation code. First, let's break down the issues in your original implementation:

• No argument count check: You directly access argv[1] without verifying if the user actually passed an argument. If they run the program without any input, this will cause undefined behavior (crash or weird results).
• Incorrect isdigit usage: isdigit() expects a single character (as an unsigned char), but you're passing the integer result of atoi(). For example, if input is "123", arg1 is 123, and isdigit(123) checks the ASCII character '{'—which is totally not what you want.
• No program termination on error: After printing an error message, your program still proceeds to return 0, making it look like execution succeeded even when invalid input was provided.
• Ambiguous atoi results: If the input is a non-numeric string, atoi() returns 0. But 0 is also considered an invalid non-positive integer, so you can't tell if the user entered 0 or garbage text.

Corrected Implementation #

Here's a revised version that addresses all these issues and meets your requirements:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>

int main(int argc, char **argv) {
    // Check if the user provided at least one argument
    if (argc < 2) {
        fprintf(stderr, "Error: No argument provided.\n");
        fprintf(stderr, "Usage: %s <positive-integer>\n", argv[0]);
        return EXIT_FAILURE;
    }

    char *input = argv[1];
    // Verify every character in the input is a digit
    for (size_t i = 0; input[i] != '\0'; i++) {
        if (!isdigit((unsigned char)input[i])) {
            fprintf(stderr, "Error: Not an integer.\n");
            return EXIT_FAILURE;
        }
    }

    // Convert input to a long integer (safer than atoi for larger values)
    long int value = strtol(input, NULL, 10);
    // Check if the value is a positive integer (exclude 0 and negatives)
    if (value <= 0) {
        fprintf(stderr, "Error: Not a positive integer.\n");
        return EXIT_FAILURE;
    }

    // If we reach here, input is valid
    printf("Success: Valid positive integer entered: %ld\n", value);
    return EXIT_SUCCESS;
}

Key Improvements Explained #

• Argument count validation: We first check if argc is at least 2, and print a usage message if not—this prevents crashes from missing arguments.
• Character-by-character digit check: By looping through each character in the input string, we ensure it contains only digits, so we know it's a valid integer before converting.
• Using strtol instead of atoi: strtol handles larger integer ranges than atoi and is more robust. While we already validated the input is digits, it's a safer choice for integer conversion.
• Immediate exit on error: Each invalid case triggers return EXIT_FAILURE right after printing the error, so the program doesn't continue executing as if nothing went wrong.
• Clear positive integer check: value <= 0 explicitly rejects both negative numbers and 0, which aligns with your requirement that 0 isn't considered a positive integer.

Optional Adjustment (If You Allow Leading '+' Sign) #

If you want to accept inputs like +123 as valid positive integers, modify the character check loop to allow a leading '+' (but only one, and only at the start):

size_t i = 0;
// Allow an optional leading '+' sign
if (input[0] == '+') {
    i = 1;
    // If the only character is '+', it's invalid
    if (input[i] == '\0') {
        fprintf(stderr, "Error: Not an integer.\n");
        return EXIT_FAILURE;
    }
}
// Check remaining characters are digits
for (; input[i] != '\0'; i++) {
    if (!isdigit((unsigned char)input[i])) {
        fprintf(stderr, "Error: Not an integer.\n");
        return EXIT_FAILURE;
    }
}

内容的提问来源于stack exchange，提问作者Heskinammo