WinForm自定义Button单次鼠标点击触发两次Click事件问题求助

Hey, this is a super common gotcha with custom WinForms controls—let’s break down exactly why your Click event is firing twice and how to fix it:

1. Check for Manual Click Triggers in Mouse Events #

The most likely culprit is that your custom button’s constructor is handling mouse events (like MouseUp or MouseDown) and manually firing the Click event again.

WinForms already natively triggers the Click event when the user releases the mouse button over the control. If you add code like this in your constructor:

this.MouseUp += (s, e) => this.PerformClick();

You’re effectively doubling up the Click trigger—once from the system, once from your custom code.

Fix: Remove any manual calls to PerformClick() or OnClick() in your mouse event handlers. Stick to styling or non-event-triggering logic in the constructor.

2. Avoid Duplicate Click Event Subscriptions #

Another common issue is accidentally subscribing to the Click event twice:

• Once in your custom button’s constructor (e.g., this.Click += CustomButton_Click;)
• Again in the parent form (either via the designer or code-behind)

Each subscription will execute the handler when the button is clicked.

Fix:

• If your custom button doesn’t need internal Click logic, remove the constructor’s Click event subscription entirely.
• If you do need internal logic, ensure the form’s binding is adding additional behavior, not repeating the same handler.

3. Check Your OnClick Override (If You’re Using It) #

If you’ve overridden the OnClick method in your custom button, make sure you’re not calling the base implementation twice. For example, this buggy code will cause double triggers:

protected override void OnClick(EventArgs e)
{
    // Your custom logic
    base.OnClick(e); // Triggers the event once
    base.OnClick(e); // Oops, triggers it a second time!
}

Fix: Call base.OnClick(e) exactly once in your override, or skip overriding the method entirely if you don’t need to extend Click logic.

4. Verify the Form’s Designer Code #

Sometimes the WinForms designer auto-generates a Click event binding, and you accidentally add another one manually in your form’s Load event or constructor.

Fix:
Open your form’s .Designer.cs file and search for lines like:

customButton1.Click += new System.EventHandler(this.customButton1_Click);

If you see duplicate entries for the same button and handler, delete the extra one.

Example of a Correct Custom Button #

Here’s a clean version that won’t cause double clicks:

public class CustomButton : Button
{
    public CustomButton()
    {
        // Add styling or setup logic here—no event triggers!
        this.Cursor = Cursors.Hand;
        this.BackColor = Color.LightSteelBlue;
    }

    // Optional: Override OnClick for custom pre/post logic
    protected override void OnClick(EventArgs e)
    {
        // Your custom logic (e.g., logging, visual feedback)
        this.ForeColor = Color.DarkSlateGray;
        
        // Call base once to trigger the normal Click event
        base.OnClick(e);
    }
}

Start with checking your constructor’s mouse event code first—it’s the most frequent cause of this issue.

内容的提问来源于stack exchange，提问作者Phạm Thế Hùng