PHP入门：while循环内查询失效及报错问题求助

Hey there! Let's walk through fixing those errors you're seeing—they're pretty straightforward once we break them down.

What the Errors Mean #

• Notice: Undefined variable: sql: This tells you that on line 121, you're trying to use a variable $sql that hasn't been created or assigned a value yet. PHP has no idea what $sql is supposed to represent here.
• Warning: mysqli_query(): Empty query: Since $sql is undefined (or ends up empty), passing it to mysqli_query() means you're asking MySQL to run an empty command—hence this warning, followed by your generic error message.

Step-by-Step Fixes #

1. Define $sql before using it in the loop
   You need to assign your actual SQL query to $sql inside your while loop (or in a spot that runs before mysqli_query()). For example, if you're updating user data based on looped results:

   while ($row = mysqli_fetch_assoc($some_result)) {
       // First, set up your SQL query clearly
       $user_id = $row['user_id'];
       // Always escape user input to avoid SQL injection!
       $updated_email = mysqli_real_escape_string($conn, $row['new_email']);
       
       $sql = "UPDATE users SET email = '$updated_email' WHERE id = $user_id";
       
       // Now execute the query
       $update_result = mysqli_query($conn, $sql);
       
       if (!$update_result) {
           // Replace generic message with specific MySQL error details
           echo "Error updating user $user_id: " . mysqli_error($conn);
       }
   }
   

2. Check for skipped assignment logic
   If you have conditional statements inside your loop (like if (...) { ... }), make sure $sql gets assigned every time the loop runs. It's easy to accidentally skip setting $sql if a condition isn't met, leading to the same undefined/empty error.

3. Debug with a quick check
   If you're still stuck, add a debug line right before mysqli_query() to see exactly what $sql contains:

   var_dump($sql); // This will show if $sql is empty, undefined, or malformed
   exit; // Pause execution to inspect the output
   

4. Use prepared statements (safer practice!)
   As a PHP beginner, avoiding SQL injection is critical. Instead of string-concatenating variables into your query, use mysqli prepared statements—they're safer and reduce syntax errors:

   while ($row = mysqli_fetch_assoc($some_result)) {
       $user_id = $row['user_id'];
       $updated_email = $row['new_email'];
       
       // Prepare the statement with placeholders
       $stmt = mysqli_prepare($conn, "UPDATE users SET email = ? WHERE id = ?");
       // Bind variables to placeholders ("si" = string + integer type)
       mysqli_stmt_bind_param($stmt, "si", $updated_email, $user_id);
       
       // Execute and check results
       if (mysqli_stmt_execute($stmt)) {
           echo "User updated successfully!";
       } else {
           echo "Error: " . mysqli_stmt_error($stmt);
       }
       
       mysqli_stmt_close($stmt);
   }
   

Quick Tip #

Ditch the generic "Error updating your user." message and use mysqli_error($conn) (or mysqli_stmt_error($stmt) for prepared statements)—this gives you the exact MySQL error, which is way more helpful for debugging.

内容的提问来源于stack exchange，提问作者Geoffrey Awayan