RoR应用404错误排查：新建记录时触发非新建控制器逻辑

Hey there, let's break down what's happening and fix this issue step by step.

First, let's clarify why your logic is firing when it shouldn't: Your check for id.nil? fails because the request is sending id: "new" instead of nil. This usually happens because of a routing or frontend mistake where the "new" path segment gets passed as an ID parameter.

Here's how to diagnose and fix this:

1. Switch to Rails' Built-in new_record? for Robust State Checking #

Instead of relying on id.nil? to determine if a record is new, use Rails' native new_record? method. This method directly checks whether the record has been persisted to the database, which is far more reliable than checking the ID (since IDs can be non-nil even for unsaved records in some edge cases, or in your scenario, a string "new" gets passed).

For example, replace your existing condition:

if !@your_model.id.nil?
  # Non-new record logic that's firing incorrectly
end

With:

if !@your_model.new_record?
  # This will only run for saved records, regardless of ID value
end

This change alone will prevent the logic from running on new records, even if the ID parameter is messed up.

2. Find Where "new" Is Being Passed as the ID #

Now let's track down why the ID is set to "new":

• Check your routes: If you're using resources :your_models, the new record path is /your_models/new—this shouldn't pass an ID parameter. But if your frontend is mistakenly using a path like /your_models/new as a member route (e.g., your_model_path("new") instead of new_your_model_path), it'll send id: "new".
• Inspect frontend forms/requests: Open your browser's DevTools, go to the Network tab, and look at the request that's causing the issue. Check the form's action attribute or AJAX URL:
  • If using form_with, make sure you're passing the model correctly (form_with(model: @your_model)). Rails automatically sets the correct action (create path for new records) when you do this.
  • If you're hardcoding the form action or AJAX URL, double-check that you're not accidentally including "new" as the ID. For example, avoid url: your_model_path("new")—use url: your_models_path for create requests.
• Check JS code: If the request is triggered by JavaScript, look for places where you're grabbing an ID from the DOM. It's possible you're selecting an element with text "new" and using that as the ID parameter.

3. Verify Controller Record Loading #

If you're loading the record with something like @your_model = YourModel.find_by(id: params[:id]) || YourModel.new, when params[:id] is "new", find_by will return nil, so it'll initialize a new record—but if you're manually assigning @your_model.id = params[:id] somewhere, that would set the ID to the string "new", making id.nil? return false. If that's the case, stop manually assigning the ID from params for new records—let Rails handle it automatically.

By combining the new_record? fix with tracking down the frontend/routing issue, you'll resolve both the misexecuted logic and the root cause of the "new" ID parameter.

内容的提问来源于stack exchange，提问作者ZpfSysn