C++字符串查找替换问题：非起始位置子串替换失败求助

Hey there! It sounds like your current code is only targeting the first occurrence of "ha" at the start of the string instead of all instances. Let's break down what's probably going wrong and how to fix it.

Common Mistake That Causes This Issue #

Chances are, your code is either checking if the substring starts at position 0 (the beginning of the string) or only runs the replacement once. For example, a snippet like this would fail for "lol haha":

std::string str = "lol haha";
size_t pos = str.find("ha");
// Only replace if "ha" is at the start
if (pos == 0) {
    str.replace(pos, 2, "wk");
}

Or even this, which only replaces the first occurrence (turning "lol haha" into "lol wkha" — still leaving the second "ha" untouched):

size_t pos = str.find("ha");
if (pos != std::string::npos) {
    str.replace(pos, 2, "wk");
}

The Correct Approach: Replace All Occurrences #

To replace every instance of "ha" with "wk" regardless of where it is in the string, you need to loop through the string, finding each match and replacing it until there are no more left. Here's a reusable function to do that:

#include <string>

void replaceAllSubstrings(std::string& inputStr, const std::string& searchStr, const std::string& replaceStr) {
    size_t currentPos = 0;
    // Keep searching until we can't find the substring anymore
    while ((currentPos = inputStr.find(searchStr, currentPos)) != std::string::npos) {
        // Replace the found substring
        inputStr.replace(currentPos, searchStr.length(), replaceStr);
        // Move past the replaced text to avoid infinite loops (critical if replaceStr contains searchStr)
        currentPos += replaceStr.length();
    }
}

How to Use It #

Here's how you'd apply this to your specific case:

int main() {
    std::string str = "lol haha";
    std::string str2 = "wk"; // Your replacement string
    replaceAllSubstrings(str, "ha", str2);
    
    // Now str will be "lol wkwk" instead of leaving the second "ha" untouched
    return 0;
}

Key Notes #

• The loop continues calling find() starting from the position right after the last replacement, ensuring we catch every occurrence.
• We use searchStr.length() instead of hardcoding 2 for "ha" — this makes the function work for any search substring, not just two characters.
• Moving currentPos by replaceStr.length() prevents infinite loops (for example, if you were replacing "a" with "aa", you'd keep matching the new "a" if you didn't advance past it).

This should fix your issue, whether the "ha" is at the start of the string or buried in the middle!

内容的提问来源于stack exchange，提问作者Michael