技术问询：JPanel中JLabel移动、游戏桶自动下落及paintcomponent用法疑问

Hey there! Let's work through your Swing game issues step by step—sounds like you're stuck with getting that bucket to fall automatically, and wondering if your paintComponent() approach is the problem. Spoiler: you’re probably right about the paintComponent part, so let’s fix that and get everything running smoothly.

Here’s the thing: paintComponent() is only meant for drawing the current state of your panel. Swing calls this method automatically whenever it needs to refresh the UI (like when you resize the window, minimize it, or another component covers yours). You have no control over how often it runs, so putting position-updating logic here will lead to weird behavior—your bucket might jump around, speed up randomly, or even freeze. Keep paintComponent strictly for drawing, not updating.

Swing has a built-in Timer class made exactly for this kind of periodic UI updates. It runs on the Event Dispatch Thread (EDT), so you won’t run into thread-safety issues with Swing components. Here’s how to implement it:

If your bucket is a custom-drawn object (not a JLabel): #

public class GamePanel extends JPanel {
    private int bucketX = 100; // Starting X position
    private int bucketY = 0;   // Starting Y position
    private final int FALL_SPEED = 5;
    private CarPanel car; // Your existing car component

    public GamePanel() {
        setLayout(null); // Absolute layout works well for moving components
        car = new CarPanel();
        add(car);
        car.setLocation(200, 400); // Set car's starting position

        // Create the timer to update the bucket every 30ms (~30 FPS)
        Timer fallTimer = new Timer(30, e -> {
            // Update bucket position
            bucketY += FALL_SPEED;

            // Reset bucket if it goes off-screen
            if (bucketY > getHeight()) {
                bucketY = 0;
                // Randomize X position for new bucket spawns
                bucketX = (int) (Math.random() * (getWidth() - 50)); // Assume bucket is 50px wide
            }

            // Trigger a repaint to draw the updated state
            repaint();
        });
        fallTimer.start(); // Start the timer!
    }

    @Override
    protected void paintComponent(Graphics g) {
        super.paintComponent(g); // Always call this first to clear the panel
        // Draw your bucket (replace with drawImage if using a sprite)
        g.setColor(Color.DARK_GRAY);
        g.fillRect(bucketX, bucketY, 50, 50);
        // Your car component will draw itself since it's added to the panel
    }
}

If your bucket is a JLabel: #

If you’re using a JLabel for the bucket, you just need to update its position directly in the timer:

private JLabel bucketLabel;

public GamePanel() {
    setLayout(null);
    // Initialize the bucket JLabel with your image
    bucketLabel = new JLabel(new ImageIcon("bucket.png"));
    bucketLabel.setSize(50, 50);
    bucketLabel.setLocation(100, 0);
    add(bucketLabel);

    car = new CarPanel();
    add(car);
    car.setLocation(200, 400);

    Timer fallTimer = new Timer(30, e -> {
        int currentY = bucketLabel.getY();
        currentY += FALL_SPEED;

        if (currentY > getHeight()) {
            currentY = 0;
            int randomX = (int) (Math.random() * (getWidth() - bucketLabel.getWidth()));
            bucketLabel.setX(randomX);
        }

        bucketLabel.setY(currentY);
        // No need for repaint here usually, but add it if the bucket doesn't update
        // repaint();
    });
    fallTimer.start();
}

KeyListener has a common gotcha: it only works if the component has focus. If your CarPanel isn’t focused, your key presses won’t register. To fix this quickly, add these lines to your CarPanel’s constructor:

public CarPanel() {
    setFocusable(true);
    requestFocusInWindow();
}

But a better long-term solution is to use Key Bindings—they don’t depend on focus, so your car will respond to keys no matter what component is focused. Here’s how to set them up in your GamePanel:

public GamePanel() {
    // ... existing code ...

    // Set up key bindings for left/right movement
    InputMap inputMap = getInputMap(JComponent.WHEN_IN_FOCUSED_WINDOW);
    ActionMap actionMap = getActionMap();

    // Left arrow key
    inputMap.put(KeyStroke.getKeyStroke(KeyEvent.VK_LEFT, 0), "moveLeft");
    actionMap.put("moveLeft", new AbstractAction() {
        @Override
        public void actionPerformed(ActionEvent e) {
            car.setLocation(car.getX() - 10, car.getY());
        }
    });

    // Right arrow key
    inputMap.put(KeyStroke.getKeyStroke(KeyEvent.VK_RIGHT, 0), "moveRight");
    actionMap.put("moveRight", new AbstractAction() {
        @Override
        public void actionPerformed(ActionEvent e) {
            car.setLocation(car.getX() + 10, car.getY());
        }
    });
}

• Separate logic (position updates, game rules) from drawing (paintComponent() only draws what’s already calculated)
• Use Swing Timer for periodic updates—never use Thread.sleep() or raw Threads for UI updates
• Prefer Key Bindings over KeyListener for better focus handling

内容的提问来源于stack exchange，提问作者Marko Marinkovic