JavaScript中Project Euler最大质因数问题排查及数组最大值咨询

Hey there! Let's tackle your two questions one by one—first that stubborn bug with the 29 log, then the array max question.

Why isn't the 29 console.log firing & num never hits 1? #

The most likely culprit here is an issue with your checkIfPrime function, or a small logic error in how you're updating num during factorization. Let's break down common pitfalls:

1. Broken prime check function
   If checkIfPrime(29) is returning false when it should return true, your code will skip the log and never update num to 1. Double-check your prime check logic:

   • Did you handle edge cases (like 2, the only even prime)?
   • Are you looping up to Math.sqrt(n) (instead of n/2 or n—both work but sqrt is more efficient)?
   • Is your return logic reversed? For example, returning true as soon as a non-divisor is found (wrong) instead of returning false when a divisor is found, then true after the loop finishes (correct).

   Here's a solid working version for reference:

   function checkIfPrime(n) {
     if (n <= 1) return false;
     if (n === 2) return true;
     if (n % 2 === 0) return false; // Skip even numbers after 2
     for (let i = 3; i <= Math.sqrt(n); i += 2) {
       if (n % i === 0) return false;
     }
     return true;
   }
   

2. Non-integer num values
   If at any point num becomes a floating-point number (instead of an integer), num % i might never equal 0, even when i is a valid factor. Make sure you're using integer division—replace num = num / i with num = Math.floor(num / i) or use num = num / i only when you know the division is exact (which it should be for prime factors, but better safe than sorry).

3. Loop condition misstep
   Double-check your outer loop (the one that runs until num === 1). If it's written as while (num > 2) or something similar instead of while (num > 1), it'll stop before processing the final prime factor (29 in this case).

Correct ways to get the max value from an integer array #

You've got a few reliable options here, depending on your use case:

• Simplest: Math.max(...array)
  Spread the array into Math.max—it's concise and easy to read:

  const factors = [5, 7, 13, 29];
  const largest = Math.max(...factors); // Returns 29
  

  Note: This can hit a limit if your array is extremely large (like 10k+ elements), but it's perfect for Project Euler problems.

• Most robust: Array.reduce()
  Use reduce to iterate and track the maximum value—great for large arrays or if you want more control:

  const factors = [5, 7, 13, 29];
  const largest = factors.reduce((currentMax, num) => {
    return num > currentMax ? num : currentMax;
  }, -Infinity); // Start with -Infinity to handle negative numbers too
  

• Manual loop (for learning purposes)
  If you want to understand the underlying logic, a simple loop works too:

  function getArrayMax(arr) {
    if (arr.length === 0) return null; // Handle empty array case
    let max = arr[0];
    for (const num of arr) {
      if (num > max) {
        max = num;
      }
    }
    return max;
  }
  

内容的提问来源于stack exchange，提问作者Canovice