如何改写if语句使其生效？命令行参数文本处理程序实现咨询

Hey there! Let's break down how to fix your if statements and build this word-count program properly—chances are your original logic was tripping up on unvalidated command-line arguments or messy branching that didn't account for all edge cases.

First: Fix Command-Line Argument Parsing (The Root of Your If Statement Woes) #

A common mistake with programs using argc/argv is skipping validation for options that require extra arguments (like -i needing an input filename). Let's rewrite this part with clear, robust if/else logic:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>

int main(int argc, char *argv[]) {
    char *input_file = NULL;
    char *output_file = NULL;
    int convert_clean = 0; // Tracks if the -c flag is enabled

    // Parse command-line arguments
    for (int i = 1; i < argc; i++) {
        if (strcmp(argv[i], "-i") == 0) {
            // Check if there's a filename after the -i option
            if (i + 1 < argc) {
                input_file = argv[++i];
            } else {
                fprintf(stderr, "Error: -i needs an input filename (e.g., -i input.txt)\n");
                return EXIT_FAILURE;
            }
        } else if (strcmp(argv[i], "-o") == 0) {
            // Check if there's a filename after the -o option
            if (i + 1 < argc) {
                output_file = argv[++i];
            } else {
                fprintf(stderr, "Error: -o needs an output filename (e.g., -o output.txt)\n");
                return EXIT_FAILURE;
            }
        } else if (strcmp(argv[i], "-c") == 0) {
            convert_clean = 1;
        } else {
            fprintf(stderr, "Error: Unknown argument '%s'\n", argv[i]);
            return EXIT_FAILURE;
        }
    }

    // Rest of the program logic goes here...
}

This loop uses explicit if/else chains to handle each option, and adds critical validation to ensure required filenames are provided. No more broken logic from unstructured or unvalidated if statements!

Step 2: Handle Input (File or User Prompt) #

Next, use if/else checks to decide whether to read from a file or prompt the user for input:

FILE *input_stream;
if (input_file != NULL) {
    input_stream = fopen(input_file, "r");
    if (input_stream == NULL) {
        perror("Failed to open input file");
        return EXIT_FAILURE;
    }
} else {
    // No input file specified: ask the user for text
    printf("Enter your text (press Ctrl+D to finish):\n");
    input_stream = stdin;
}

Step 3: Process Text (If -c Is Enabled) #

Use if checks to toggle text cleaning (uppercase to lowercase, remove punctuation) when the -c flag is set:

#define BUFFER_SIZE 1024
char buffer[BUFFER_SIZE];
char processed_text[BUFFER_SIZE] = {0};
int proc_idx = 0;

while (fgets(buffer, BUFFER_SIZE, input_stream) != NULL) {
    for (int i = 0; buffer[i] != '\0'; i++) {
        if (convert_clean) {
            // Convert uppercase letters to lowercase
            char c = tolower(buffer[i]);
            // Skip punctuation characters
            if (!ispunct(c)) {
                processed_text[proc_idx++] = c;
            }
        } else {
            processed_text[proc_idx++] = buffer[i];
        }
    }
}
processed_text[proc_idx] = '\0'; // Null-terminate the processed string

Step 4: Count Words & Frequencies #

Finally, use if logic to handle two cases: just counting total words, or counting word frequencies when -c is enabled:

// Helper function to split text into individual words
char** split_words(const char *str, int *total_words) {
    char **words = NULL;
    char *token = strtok((char*)str, " \n\t");
    *total_words = 0;

    while (token != NULL) {
        words = realloc(words, (*total_words + 1) * sizeof(char*));
        words[*total_words] = strdup(token);
        (*total_words)++;
        token = strtok(NULL, " \n\t");
    }
    return words;
}

int word_count = 0;
char** words = split_words(processed_text, &word_count);

// Open output stream (file or stdout if no -o specified)
FILE *output_stream = (output_file != NULL) ? fopen(output_file, "w") : stdout;
if (output_stream == NULL) {
    perror("Failed to open output file");
    return EXIT_FAILURE;
}

if (convert_clean) {
    // Count word frequencies
    int *freq_counts = calloc(word_count, sizeof(int));
    for (int i = 0; i < word_count; i++) {
        if (freq_counts[i] == -1) continue; // Skip already counted words
        freq_counts[i] = 1;
        for (int j = i + 1; j < word_count; j++) {
            if (strcmp(words[i], words[j]) == 0) {
                freq_counts[i]++;
                freq_counts[j] = -1; // Mark as counted to avoid duplicates
            }
        }
    }

    // Write results to output
    fprintf(output_stream, "Total words: %d\n", word_count);
    fprintf(output_stream, "Word frequencies:\n");
    for (int i = 0; i < word_count; i++) {
        if (freq_counts[i] != -1) {
            fprintf(output_stream, "%s: %d\n", words[i], freq_counts[i]);
        }
    }
    free(freq_counts);
} else {
    // Just write total word count
    fprintf(output_stream, "Total words: %d\n", word_count);
}

// Clean up memory and files
for (int i = 0; i < word_count; i++) {
    free(words[i]);
}
free(words);
fclose(input_stream);
fclose(output_stream);

return EXIT_SUCCESS;
}

Key Fixes to Your If Statements #

• Validation Checks: Added if conditions to ensure options like -i and -o have required filenames, preventing crashes from missing arguments.
• Clear Branching: Used if/else chains to handle each command-line option explicitly, avoiding messy nested logic.
• Flag-Driven Logic: Used the convert_clean flag to toggle text processing, making the code modular and easy to follow.

Extra Notes #

• The split_words function uses strtok to split text on whitespace; adjust the delimiters if your definition of a "word" includes other characters.
• For very large files, modify the buffer approach to process text in chunks without loading everything into memory.
• Always free dynamically allocated memory to avoid leaks!

内容的提问来源于stack exchange，提问作者Venetsia Krasteva