读取文件数据创建struct的vector失败，vector大小为0求排查

Hey there! Let's figure out why your vector is coming up empty—file I/O issues in C++ are super common, so we'll walk through the most likely fixes step by step.

Common Culprits & Fixes #

1. Your Program Can't Find the File #

This is the #1 reason for empty vectors when reading files. If qbdata.txt isn't in the working directory where your program runs (not necessarily where your source code is), the ifstream will fail to open it silently, and all subsequent read operations will do nothing.

Quick test: Add a check right after opening the file to confirm it's accessible:

ifstream infile("qbdata.txt");
if (!infile.is_open()) {
    cerr << "Oops! Couldn't open qbdata.txt. Double-check the file path!" << endl;
    return 1;
}

If this error prints, try using an absolute path (like C:/projects/qbdata.txt on Windows or /home/you/projects/qbdata.txt on Linux/macOS) to rule out path issues.

2. You're Not Checking for Read Failures #

Even if the file opens, if your read operations don't match the file's data format, the stream will enter a failed state, and your loop will stop immediately (leaving the vector empty).

Fix: Use the read operation itself as your loop condition (this checks if the read succeeded before adding to the vector):

Record temp;
// Replace with your struct's actual fields in the order they appear in the file
while (infile >> temp.name >> temp.attempts >> temp.completions) {
    quarterbacks.push_back(temp);
}

After the loop, add checks to see why it stopped:

if (infile.bad()) {
    cerr << "Serious error reading the file (corrupted data?)" << endl;
} else if (infile.fail()) {
    cerr << "Failed to read a record—make sure your struct's types match the file's format!" << endl;
}

3. Your Struct Doesn't Match the File's Data Format #

If the order, type, or number of fields in your Record struct doesn't exactly match what's in qbdata.txt, the read operation will fail. For example:

• If your struct expects an int but the file has a string here, the stream will fail.
• If the file has a first name + last name as separate fields but your struct uses a single string name, the first read will grab the first name, the next will grab the last name (mismatching your struct's fields), and the stream will fail.

Fix: Double-check the file's structure (your uploaded snippet helps here!) and align your struct's fields exactly. For example, if the file lines look like:

Brady 638 401
Mahomes 580 373

Your struct should be:

struct Record {
    string lastName;
    int attempts;
    int completions;
};

And your read loop should match that order.

4. You're Using while (infile.eof()) (A Common Mistake!) #

If your loop uses while (infile.eof()), this will cause issues because eof() only returns true after a read operation fails to reach the end of the file. This means you might try to read an invalid record, or the loop might not run at all if the file is empty (or if the first read fails).

Fix: Use the read operation as the loop condition like I showed earlier—it's the safest way to handle file reads in C++.

5. The File Has Header Lines or Extra Whitespace #

If qbdata.txt starts with a header line (like "Name Attempts Completions"), you need to skip that line before reading records. Otherwise, your first read will try to parse the header text as a data record, which will fail and stop the loop.

Fix: Add a line to skip the header:

string headerLine;
getline(infile, headerLine); // Skips the first line

Just make sure this comes after confirming the file is open, and before your read loop.

Example Working Code Snippet #

Here's a complete example tying all these fixes together:

#include <iostream>
#include <fstream>
#include <vector>
#include <string>

using namespace std;

struct Record {
    string lastName;
    int attempts;
    int completions;
};

int main() {
    vector<Record> quarterbacks;
    ifstream infile("qbdata.txt");

    // Check if file opened successfully
    if (!infile) {
        cerr << "Error: Could not open qbdata.txt" << endl;
        return 1;
    }

    // Skip header line (if your file has one)
    string header;
    getline(infile, header);

    Record temp;
    // Read records until end of file or error
    while (infile >> temp.lastName >> temp.attempts >> temp.completions) {
        quarterbacks.push_back(temp);
    }

    // Diagnose any read issues
    if (infile.fail() && !infile.eof()) {
        cerr << "Warning: Failed to read some data—check struct vs file format!" << endl;
    }

    cout << "Total records read: " << quarterbacks.size() << endl;

    return 0;
}

Start with checking if the file opens, then verify your struct matches the file's format, and adjust your read loop accordingly—this should get your vector populated in no time!

内容的提问来源于stack exchange，提问作者Phyllis Qu