Fragment动态ListView位置重复求助：修改数量时索引联动变化

Hey there! Let's break down why your ListView is acting up—this is a classic pitfall with ListView's view recycling system, but it's easy to fix once you know what's going on.

The Root Cause #

ListView reuses views (via convertView) to save memory, especially when scrolling. When you see position 7 syncing with position 0, it's because the view for position 7 is actually the recycled view from position 0. The problem is you're storing the item quantity and total price in the View itself (like the TextView's text) instead of tying that state to your DataModel. So when the view gets reused, it carries over the old state, and your click events end up modifying the wrong data because of outdated tags.

Step-by-Step Fix #

1. Update Your DataModel to Track Item State

First, add fields to your DataModel to store each item's quantity and total price. This way, every item's state is tied to its data, not the reusable view:

public class DataModel {
    // Your existing fields
    private String itemTitleFinal;
    private String itemPriceFinal;
    private int itemImgFinal;
    
    // New state fields
    private int quantity = 0;
    private int totalPrice = 0;

    // Getters and Setters
    public String getItemTitleFinal() { return itemTitleFinal; }
    public void setItemTitleFinal(String itemTitleFinal) { this.itemTitleFinal = itemTitleFinal; }

    public String getItemPriceFinal() { return itemPriceFinal; }
    public void setItemPriceFinal(String itemPriceFinal) { 
        this.itemPriceFinal = itemPriceFinal;
        // Update total price when price changes
        this.totalPrice = Integer.parseInt(itemPriceFinal) * quantity;
    }

    public int getItemImgFinal() { return itemImgFinal; }
    public void setItemImgFinal(int itemImgFinal) { this.itemImgFinal = itemImgFinal; }

    public int getQuantity() { return quantity; }
    public void setQuantity(int quantity) {
        this.quantity = quantity;
        // Auto-calculate total price when quantity changes
        int itemPrice = Integer.parseInt(this.itemPriceFinal);
        this.totalPrice = itemPrice * quantity;
    }

    public int getTotalPrice() { return totalPrice; }
}

2. Rewrite the getView Method to Bind Data Correctly

Modify your adapter's getView method to always pull state from the DataModel (not the view) and update the UI accordingly. Also, remove the unreliable tag-based logic—we'll use the directly referenced DataModel instead:

@NonNull 
@Override 
public View getView(int position, @Nullable View convertView, @NonNull ViewGroup parent) { 
    ViewHolder holder; 
    LayoutInflater inflater = (LayoutInflater) activity.getSystemService(Activity.LAYOUT_INFLATER_SERVICE); 

    // Initialize or reuse the ViewHolder
    if (convertView == null) { 
        convertView = inflater.inflate(R.layout.food_item_list, parent, false); 
        holder = new ViewHolder(convertView); 
        convertView.setTag(holder); 
    } else { 
        holder = (ViewHolder) convertView.getTag(); 
    } 

    // Get the current item's data model
    final DataModel dataModel = getItem(position); 
    if (dataModel == null) return convertView;

    // Update ALL UI elements using data from the DataModel
    holder.foodItem.setText(dataModel.getItemTitleFinal()); 
    holder.foodPrice.setText(dataModel.getItemPriceFinal()); 
    holder.foodType.setImageResource(dataModel.getItemImgFinal()); 
    holder.qty.setText(String.valueOf(dataModel.getQuantity())); 
    holder.priceCurnt.setText(String.valueOf(dataModel.getTotalPrice())); 

    // Add Button Click Logic (updates DataModel first, then UI)
    holder.addBtn.setOnClickListener(v -> {
        int newQuantity = dataModel.getQuantity() + 1;
        dataModel.setQuantity(newQuantity);
        // Refresh UI to reflect new state
        holder.qty.setText(String.valueOf(newQuantity));
        holder.priceCurnt.setText(String.valueOf(dataModel.getTotalPrice()));
        // Update your total cost tracker
        int itemPrice = Integer.parseInt(dataModel.getItemPriceFinal());
        new MenuPage().addItem(itemPrice);
    }); 

    // Remove Button Click Logic
    holder.removeBtn.setOnClickListener(v -> {
        if (dataModel.getQuantity() > 0) {
            int newQuantity = dataModel.getQuantity() - 1;
            dataModel.setQuantity(newQuantity);
            holder.qty.setText(String.valueOf(newQuantity));
            holder.priceCurnt.setText(String.valueOf(dataModel.getTotalPrice()));
            int itemPrice = Integer.parseInt(dataModel.getItemPriceFinal());
            new MenuPage().removeItem(itemPrice);
        } else {
            Toast.makeText(getContext(), "Add Item First", Toast.LENGTH_SHORT).show();
        }
    }); 

    return convertView; 
}

3. Clean Up Unnecessary Code

• Remove all the setTag(position) calls on your views—they're no longer needed since we're directly using the DataModel from the current position.
• In the original code, you were calling convertView.findViewById inside the convertView == null block even though the ViewHolder already references those views. The updated code uses the ViewHolder exclusively, which is more efficient.

Why This Works #

By storing each item's quantity and total price in the DataModel, you ensure that every time a view is reused (for a different position), it gets updated with the correct data for that position. Click events now modify the DataModel directly, so changes are tied to the item itself, not the reusable view.

内容的提问来源于stack exchange，提问作者Rahul Pathak