Laravel 5.5：通过用户ID获取发件人邮箱及相关开发疑问

Hey there! Let’s break down your three questions about handling user messages in Laravel, using your provided code as a starting point.

1. Can we modify the messages array to format dates and fetch sender emails? #

Absolutely! There are a couple of clean ways to do this:

Option 1: Transform the collection directly in the user_messages function #

Instead of just echoing values, you can adjust each message in the loop to add formatted dates and sender emails. Here’s a revised version of your function:

public function user_messages() {
    $user_id = Auth::user()->id;
    $messages = Message::where('to', $user_id)->get();
    
    // Transform each message with desired data
    $processedMessages = $messages->map(function($message) {
        return [
            'subject' => $message->subject,
            'content' => $message->message,
            'sender_email' => $this->getEmail($message->from),
            'formatted_sent_date' => $message->created_at->format('Y-m-d H:i:s') // Adjust format to your needs
        ];
    });
    
    return $processedMessages;
}

Option 2: Use Laravel Eloquent Accessors (more scalable) #

For a cleaner, maintainable approach, define accessors in your Message model to auto-format dates and fetch sender data. This way, the transformation happens automatically whenever you access those attributes:

// In your Message model
public function getFormattedSentDateAttribute() {
    return $this->created_at->format('Y-m-d H:i:s');
}

public function sender() {
    return $this->belongsTo(User::class, 'from'); // Define the sender relationship
}

// Updated user_messages function with eager loading (avoids N+1 queries)
public function user_messages() {
    $user_id = Auth::user()->id;
    return Message::where('to', $user_id)->with('sender')->get();
}

// Now you can access these directly:
// $message->formatted_sent_date
// $message->sender->email

2. Can the user_messages function be called in other view-returning controllers? #

Yes! But first, you’ll want to fix one key issue: your current function echoes values instead of returning the collection (your commented-out return $messages; is the right direction).

How to reuse it across controllers: #

• If user_messages lives in a base controller (like Controller.php that all other controllers extend), you can call it directly:

  // In another controller (e.g., DashboardController)
  public function index() {
      $userMessages = $this->user_messages();
      return view('dashboard', compact('userMessages'));
  }
  

• If it’s in a dedicated MessageController, you can inject that controller or move the logic to a service class for better reusability (great for larger apps).

Just ensure the function has public visibility and returns the processed/raw messages instead of echoing output.

3. Is your getEmail method reasonable? #

It works for basic scenarios, but it has a critical flaw: it will throw an error if no user exists with the given $id (since first() returns null, and accessing ->email on null causes a Trying to get property 'email' of non-object exception).

Improved version of getEmail: #

public function getEmail($id) {
    $user = User::find($id);
    // Return a fallback value if the user doesn't exist
    return $user ? $user->email : 'Unknown Sender';
}

Even better: Use Eloquent relationships #

As mentioned in question 1, defining a sender relationship in your Message model eliminates the need for a separate getEmail method entirely. It also fixes N+1 database query issues by using eager loading (with('sender')), making your code more efficient.

内容的提问来源于stack exchange，提问作者Andreas Hunter