ComboBox选中项变更时TextBox自动填充问题求助（基于SQL Server）

嘿，我看了你遇到的问题——ComboBox能正常加载下拉项，但选中后TextBox没反应，咱们一步步排查并解决这个问题：

1. 你的代码里的几个直接问题 #

未声明的cmd变量 #

在CBoxParishDdlist_SelectedIndexChanged方法里，你直接用了cmd但没声明，如果它不是全局变量的话，这会直接导致编译错误，得先显式声明它。

多余的ExecuteNonQuery()调用 #

ExecuteNonQuery()是用来执行增删改这类不返回结果的SQL语句的，查询数据根本不需要调用它，这个多余的操作不仅浪费资源，还可能埋下隐患。

高危的SQL注入风险 #

你用字符串拼接构造SQL："SELECT * FROM Competitors WHERE ParishName = '" + CBoxParishDdlist.Text + "'"，这不仅容易被SQL注入攻击，要是ParishName里带个单引号，直接就会触发SQL语法错误，必须改用参数化查询。

未处理数据库NULL值 #

如果数据库里某个字段是NULL，dr["Institution"].ToString()会直接抛出异常，代码中断后TextBox自然不会被填充。

数据库连接未安全释放 #

直接调用connect.Close()，要是中间出现异常，连接可能没法正常关闭，应该用using语句自动管理连接生命周期。

2. 修复后的完整代码 #

优化后的ComboBox加载方法 #

private void RabbitCare_Load(object sender, EventArgs e)
{
    CBoxParishDdlist.Items.Clear();
    // using语句自动释放连接，不用手动Close
    using (SqlConnection connect = new SqlConnection(@"Data Source=ITSPECIALIST\SQLPROJECTS;Initial Catalog=EXPRORESULTS;Integrated Security=True "))
    {
        connect.Open();
        // 用参数化查询养成好习惯，哪怕参数固定
        using (SqlCommand cmd = new SqlCommand("Select ParishName FROM Competitors WHERE CompetitiveEventName = @EventName", connect))
        {
            cmd.Parameters.AddWithValue("@EventName", "Care and Management of Bees");
            DataTable dat = new DataTable();
            SqlDataAdapter SDA = new SqlDataAdapter(cmd);
            SDA.Fill(dat);
            foreach (DataRow DAR in dat.Rows)
            {
                CBoxParishDdlist.Items.Add(DAR["ParishName"].ToString());
            }
        }
    }
}

修复后的SelectedIndexChanged事件 #

private void CBoxParishDdlist_SelectedIndexChanged(object sender, EventArgs e)
{
    // 先判断是否选中了有效项
    if (CBoxParishDdlist.SelectedIndex == -1)
    {
        // 清空所有TextBox
        TxtBoxInstitution.Text = "";
        TxtBoxRegion.Text = "";
        TxtBoxFname.Text = "";
        TxtBoxLname.Text = "";
        return;
    }

    string selectedParish = CBoxParishDdlist.SelectedItem.ToString();
    using (SqlConnection connect = new SqlConnection(@"Data Source=ITSPECIALIST\SQLPROJECTS;Initial Catalog=EXPRORESULTS;Integrated Security=True "))
    {
        connect.Open();
        // 参数化查询，彻底避免SQL注入和语法错误
        using (SqlCommand cmd = new SqlCommand("SELECT Institution, Region, FirstName, LastName FROM Competitors WHERE ParishName = @ParishName", connect))
        {
            cmd.Parameters.AddWithValue("@ParishName", selectedParish);
            using (SqlDataReader dr = cmd.ExecuteReader())
            {
                if (dr.Read()) // 只取第一行，如果ParishName唯一的话
                {
                    // 处理NULL值，为空时显示空字符串
                    TxtBoxInstitution.Text = dr["Institution"] != DBNull.Value ? dr["Institution"].ToString() : "";
                    TxtBoxRegion.Text = dr["Region"] != DBNull.Value ? dr["Region"].ToString() : "";
                    TxtBoxFname.Text = dr["FirstName"] != DBNull.Value ? dr["FirstName"].ToString() : "";
                    TxtBoxLname.Text = dr["LastName"] != DBNull.Value ? dr["LastName"].ToString() : "";
                }
                else
                {
                    // 没找到匹配数据时清空TextBox
                    TxtBoxInstitution.Text = "";
                    TxtBoxRegion.Text = "";
                    TxtBoxFname.Text = "";
                    TxtBoxLname.Text = "";
                }
            }
        }
    }
}

3. 额外优化建议 #

• 如果ParishName在数据库里可能重复，建议绑定数据时带上唯一标识（比如CompetitorID），用ValueMember存储ID，查询时用ID匹配更准确：

  // 加载ComboBox时绑定完整数据源
  private void RabbitCare_Load(object sender, EventArgs e)
  {
      using (SqlConnection connect = new SqlConnection(@"Data Source=ITSPECIALIST\SQLPROJECTS;Initial Catalog=EXPRORESULTS;Integrated Security=True "))
      {
          connect.Open();
          using (SqlCommand cmd = new SqlCommand("Select ParishName, CompetitorID FROM Competitors WHERE CompetitiveEventName = @EventName", connect))
          {
              cmd.Parameters.AddWithValue("@EventName", "Care and Management of Bees");
              DataTable dat = new DataTable();
              SqlDataAdapter SDA = new SqlDataAdapter(cmd);
              SDA.Fill(dat);
              CBoxParishDdlist.DataSource = dat;
              CBoxParishDdlist.DisplayMember = "ParishName";
              CBoxParishDdlist.ValueMember = "CompetitorID";
          }
      }
  }
  

  然后在事件里用ID查询：

  int competitorId = (int)CBoxParishDdlist.SelectedValue;
  cmd.Parameters.AddWithValue("@CompetitorId", competitorId);
  // SQL改为 WHERE CompetitorID = @CompetitorId
  

• 把数据库连接字符串放到App.config里，后续修改更方便，不用改动代码。

内容的提问来源于stack exchange，提问作者Dean