Java自定义retainAll方法逻辑错误排查求助

Hey there, let's take a look at your retainAll implementation—there are a few key issues that are causing it to not behave as expected. Let's break them down one by one:

• You're iterating the wrong collection: Your code uses an iterator for the input collection c, but retainAll is supposed to modify the current collection (this) by keeping only elements that exist in c. Iterating over c doesn't help you check which elements in your own list need to be removed.
• The containment check is redundant (and backwards for your goal): Since itr is an iterator for c, every element you get from itr.next() is definitely present in c. That means !c.contains(itr.next()) will never be true, so your code never actually removes any elements from your list.
• Returning too early: Even if you had the right logic, returning true immediately after removing one element would stop processing the rest of the elements, leaving unwanted items in your list. The method should only return true if any elements were removed (after processing all elements), not just the first one.

Here's the corrected implementation that matches your expected behavior:

@Override
public boolean retainAll(Collection<?> c) {
    if (c == null) {
        throw new NullPointerException("collection is null");
    }
    boolean modified = false;
    Iterator<?> itr = this.iterator(); // Iterate over the current list (listA)
    while (itr.hasNext()) {
        Object element = itr.next();
        if (!c.contains(element)) { // Remove elements NOT present in the input collection (listB)
            itr.remove();
            modified = true; // Track that we've made changes to the list
        }
    }
    return modified; // Return true only if any elements were removed
}

Let's walk through why this works for your scenario:

1. We iterate over this (your listA) instead of listB, so we can check every element in the list we want to modify.
2. For each element in listA, we check if it isn't present in listB—if that's true, we remove it from listA.
3. We use a modified flag to track if any changes were made. This aligns with the retainAll contract: return true if the collection was altered during the operation.

If you run this with your test case—listA containing "Hey", "1", "2", "3", "4", "Bro" and listB containing "Hey", "Bro"—listA will correctly retain only "Hey" and "Bro".

内容的提问来源于stack exchange，提问作者CenturiDamos