C#调用WinAPI SHAssocEnumHandlers在Win7遇E_FAIL错误求助

Let's break down why you're hitting that 0x80004005 (E_FAIL) error only on Windows 7, and how to fix it:

1. Critical Mistake: Incorrect Return Type for SHAssocEnumHandlers #

The SHAssocEnumHandlers function returns an HRESULT (a 32-bit integer error code), not a boolean. Your current code defines it as returning bool, which mangles error codes and leaves the output IEnumAssocHandlers pointer in an invalid state when the call fails. This is almost certainly the root cause of the marshaling error you're seeing on Windows 7.

2. Missing COM Initialization #

Windows 7's Shell COM interfaces require a Single-Threaded Apartment (STA) context to function correctly. Console applications don't initialize COM automatically, so you need to explicitly set this up before calling any Shell API functions.

3. Corrected Code Implementation #

Here's the revised version of your code with these fixes, plus proper COM object cleanup:

using System;
using System.Runtime.InteropServices;

namespace AssocHandlerTest
{
    [Flags]
    public enum ASSOC_FILTER
    {
        ASSOC_FILTER_NONE = 0x0,
        ASSOC_FILTER_RECOMMENDED = 0x1
    };

    [ComImport]
    [InterfaceType(ComInterfaceType.InterfaceIsIUnknown)]
    [Guid("F04061AC-1659-4a3f-A954-775AA57FC083")]
    public interface IAssocHandler
    {
        int GetName([Out, MarshalAs(UnmanagedType.LPWStr)] out string ppsz);
        int GetUIName([Out, MarshalAs(UnmanagedType.LPWStr)] out string ppsz);
        int GetIconLocation([Out, MarshalAs(UnmanagedType.LPWStr)] out string ppszPath, [Out] out int pIndex);
        int IsRecommended();
        int MakeDefault([In, MarshalAs(UnmanagedType.LPWStr)] string pszDescription);
        int Invoke([In, MarshalAs(UnmanagedType.IUnknown)] object pdo);
        int CreateInvoker([In, MarshalAs(UnmanagedType.IUnknown)] object pdo, [Out, MarshalAs(UnmanagedType.IUnknown)] out object ppInvoker);
    };

    [ComImport]
    [InterfaceType(ComInterfaceType.InterfaceIsIUnknown)]
    [Guid("973810ae-9599-4b88-9e4d-6ee98c9552da")]
    public interface IEnumAssocHandlers
    {
        int Next([In, MarshalAs(UnmanagedType.U4)] int celt, [Out, MarshalAs(UnmanagedType.Interface)] out IAssocHandler rgelt, [Out, MarshalAs(UnmanagedType.U4)] out uint pceltFetched);
        int Skip([In, MarshalAs(UnmanagedType.U4)] int celt);
        int Reset();
        int Clone([Out, MarshalAs(UnmanagedType.Interface)] out IEnumAssocHandlers ppenum);
    };

    class Program
    {
        // Correct return type: HRESULT (int) instead of bool
        [DllImport("Shell32.dll", CharSet = CharSet.Auto, PreserveSig = true)]
        static extern int SHAssocEnumHandlers(
            [In, MarshalAs(UnmanagedType.LPWStr)] string pszExtra,
            [In] ASSOC_FILTER afFilter,
            [Out, MarshalAs(UnmanagedType.Interface)] out IEnumAssocHandlers ppEnumHandler);

        [DllImport("ole32.dll")]
        static extern int CoInitializeEx(IntPtr pvReserved, uint dwCoInit);

        [DllImport("ole32.dll")]
        static extern void CoUninitialize();

        const uint COINIT_APARTMENTTHREADED = 0x2;
        const uint COINIT_DISABLE_OLE1DDE = 0x4;
        const int S_OK = 0x0;

        static void Main(string[] args)
        {
            const string extension = ".html";
            IEnumAssocHandlers enumAssocHandlers = null;
            IAssocHandler handler = null;

            try
            {
                // Initialize COM in STA mode (required for Windows 7 Shell APIs)
                int initResult = CoInitializeEx(IntPtr.Zero, COINIT_APARTMENTTHREADED | COINIT_DISABLE_OLE1DDE);
                if (initResult != S_OK && initResult != 0x80010106) // 0x80010106 = RPC_E_CHANGED_MODE (if COM was already initialized)
                {
                    throw new COMException("Failed to initialize COM", initResult);
                }

                // Call SHAssocEnumHandlers with proper HRESULT checking
                int hr = SHAssocEnumHandlers(extension, ASSOC_FILTER.ASSOC_FILTER_NONE, out enumAssocHandlers);
                if (hr != S_OK)
                {
                    throw new COMException("SHAssocEnumHandlers failed", hr);
                }

                // Enumerate the handlers
                uint fetched;
                while (enumAssocHandlers.Next(1, out handler, out fetched) == S_OK && fetched == 1)
                {
                    try
                    {
                        string name;
                        handler.GetName(out name);
                        Console.WriteLine($"Handler Name: {name}");
                    }
                    finally
                    {
                        // Clean up each handler instance
                        if (handler != null)
                        {
                            Marshal.ReleaseComObject(handler);
                            handler = null;
                        }
                    }
                }
            }
            catch (Exception ex)
            {
                Console.WriteLine($"Error: {ex.Message}");
                if (ex is COMException comEx)
                {
                    Console.WriteLine($"HRESULT: 0x{comEx.ErrorCode:X8}");
                }
            }
            finally
            {
                // Clean up the enumerator
                if (enumAssocHandlers != null)
                {
                    Marshal.ReleaseComObject(enumAssocHandlers);
                }
                CoUninitialize();
            }

            Console.ReadLine();
        }
    }
}

Key Changes Explained: #

• Fixed SHAssocEnumHandlers return type: Changed from bool to int (HRESULT) and added PreserveSig = true to ensure the raw HRESULT is returned instead of being converted to a boolean.
• Added COM initialization: Called CoInitializeEx to set up an STA context, which is mandatory for Windows 7's Shell COM components. We also handle the case where COM was already initialized in a compatible mode.
• Completed IEnumAssocHandlers interface: Added the missing Skip, Reset, and Clone methods (required for full IUnknown-derived interface compliance; omitting these can cause marshaling errors on older Windows versions).
• Proper COM object cleanup: Used Marshal.ReleaseComObject to release each IAssocHandler and the IEnumAssocHandlers instance, preventing memory leaks.
• Explicit HRESULT checking: Now we properly validate the return codes from all COM calls to catch errors early.

This should resolve the E_FAIL error on Windows 7 while maintaining compatibility with Windows 10.

内容的提问来源于stack exchange，提问作者Patrick